ORM: Fix problem with detached DbAuthInfo instances

[sphuber]

Fixes #4596

The idea is that somehow, the AuthInfo instance that is kept as a reference by the JobsList goes stale at some point when a CalcJob requests a transport through the JobManager. The fix is to use the explicit AuthInfo that is passed when request_job_info_update is called and not the one that was used to construct the original JobsList instance.

[unkcpz]

Thanks! The changes look good.
If I understand the behavior of the JobManager correctly, I guess after the job is submitted, the change to the minimum_job_interval will take effect on the job immediately without restarting the daemon?

[sphuber]

Thanks! The changes look good. If I understand the behavior of the JobManager correctly, I guess after the job is submitted, the change to the minimum_job_interval will take effect on the job immediately without restarting the daemon?

I think so yes. In aiida.engine.process.calcjobs.tasks.task_update_job the TaskManager.request_job_info_update method is called, passing the AuthInfo that is retrieved from node.get_authinfo(). But it could be that that last call is using a cached instance of AuthInfo. Then again, that should be wrapped in our ModelWrapper which ensures that fetching attributes should cause the model to be updated from the database, if the model is stored. So long story short, yes, I think this should automatically update the polling interval without restarting the daemon 😄

[unkcpz]

So long story short, yes, I think this should automatically update the polling interval without restarting the daemon 😄

This is nice!