Seperate the dev CI tests to run for dev changes #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
seperate-user-test-and-dev-test
branch
2 times, most recently
from
d476e3a to
570902e
Compare
Fixes aiidateam#306 The CI action not triggered because the changes are made not from `plugins.yaml` file, thus not trigger the CI. The following restriction is set to only trigger the preview CI to prevent the malicious code inject to CI actions. https://github.com/aiidateam/aiida-registry/blob/c306d6a7cb85ef12eba51a24d4d3f21805e70b3d/.github/workflows/ci.yml#L10-L11 In this PR, I separate the actions that test changes on other development changes to other CI which will not term out to be a preview from our official aiida official domain. Besides, I remove the pre-commit action and make it triggered from GHA integration.
unkcpz
force-pushed
the
seperate-user-test-and-dev-test
branch
from
8cb7adc to
258a0b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
The CI action not triggered because the changes are made not from
plugins.yamlfile, thus not trigger the CI.The following restriction is set to only trigger the preview CI to prevent the malicious code inject to CI actions.
aiida-registry/.github/workflows/ci.yml
Lines 10 to 11 in c306d6a
In this PR, I separate the actions that test changes on other development changes to other CI which will not term out to be a preview from our official aiida official domain. Besides, I remove the pre-commit action and make it triggered from GHA integration.