Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RmqThreadCommunicator: remove deprecated start and stop methods #125

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

sphuber
Copy link
Collaborator

@sphuber sphuber commented Oct 14, 2022

These were deprecated since v0.6.0 and were slated to be removed for v0.7.0.

Verified

This commit was signed with the committer’s verified signature.
neo1973 Markus Härer
These were deprecated since `v0.6.0` and were slated to be removed for
`v0.7.0`.
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 89.54% // Head: 89.65% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (60ca66e) compared to base (b78bbe9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   89.54%   89.65%   +0.12%     
==========================================
  Files          15       15              
  Lines        1137     1130       -7     
==========================================
- Hits         1018     1013       -5     
+ Misses        119      117       -2     
Impacted Files Coverage Δ
src/kiwipy/rmq/threadcomms.py 88.82% <ø> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sphuber sphuber merged commit 16e6056 into master Oct 14, 2022
@sphuber sphuber deleted the fix/remove-deprecated-code branch October 14, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant