-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix resolve cancellation #2910
Merged
pfreixes
merged 16 commits into
aio-libs:master
from
thehesiod-forks:thehesiod/resolve-fix
Apr 12, 2018
Merged
fix resolve cancellation #2910
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a647b47
Merge remote-tracking branch 'aio-libs/master'
thehesiod dd56884
Merge branch 'aio-libs/master'
thehesiod 5d681f6
Merge branch 'aio-libs/master'
thehesiod 2b90858
Merge branch 'aio-libs/master'
thehesiod b16fafe
Merge branch 'aio-libs/master'
thehesiod d78d618
Merge branch 'aio-libs/master'
thehesiod f8d1b60
Merge remote-tracking branch 'aio-libs/master'
thehesiod 438528c
Merge remote-tracking branch 'aio-libs/master'
thehesiod 5bff7b8
Merge remote-tracking branch 'aio-libs/master'
thehesiod 6ecd39d
Merge remote-tracking branch 'aio-libs/master'
thehesiod f66ac26
Merge remote-tracking branch 'aio-libs/master'
thehesiod 6b364a1
fix resolve cancellation
thehesiod 78bbb3b
fixes based on review
thehesiod ff63d76
changes based on review
thehesiod 7c70a0f
add changes file
thehesiod 1284612
rename
thehesiod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
fix cancellation broadcast during DNS resolve |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this
shield
[1] can be removed, it was put in place just for the situation that you are commenting but taking a look at your MR - and the shield implementation - I was wrong.[1] https://github.com/aio-libs/aiohttp/blob/master/aiohttp/connector.py#L702
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok was wondering about that, removed