From f14ad010c30811eee48225946cb761e9dce62902 Mon Sep 17 00:00:00 2001 From: Vladimir Rutsky Date: Sun, 4 Oct 2015 03:23:13 +0300 Subject: [PATCH 1/2] fix PYTHONASYNCIODEBUG and AIOHTTP_NO_EXTENSIONS usage PYTHONASYNCIODEBUG environment variable enables asyncio debug mode if it's any **non-empty** string (see ). In code it's actually implemented in the following way, which corresponds to documented behaviour: self._debug = (not sys.flags.ignore_environment and bool(os.environ.get('PYTHONASYNCIODEBUG'))) Not documented `AIOHTTP_NO_EXTENSIONS` environment variable used in the same way, so it's behaviour is the same. --- .travis.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 608149812c5..971fc52c192 100644 --- a/.travis.yml +++ b/.travis.yml @@ -31,7 +31,7 @@ script: env: matrix: - - PYTHONASYNCIODEBUG=1 AIOHTTP_NO_EXTENSIONS=0 - - PYTHONASYNCIODEBUG=0 AIOHTTP_NO_EXTENSIONS=0 - - PYTHONASYNCIODEBUG=1 AIOHTTP_NO_EXTENSIONS=1 - - PYTHONASYNCIODEBUG=0 AIOHTTP_NO_EXTENSIONS=1 + - PYTHONASYNCIODEBUG=nonemptystring AIOHTTP_NO_EXTENSIONS= + - PYTHONASYNCIODEBUG= AIOHTTP_NO_EXTENSIONS= + - PYTHONASYNCIODEBUG=nonemptystring AIOHTTP_NO_EXTENSIONS=nonemptystring + - PYTHONASYNCIODEBUG= AIOHTTP_NO_EXTENSIONS=nonemptystring From e28ca41ece100743506e874d37b6570cb9262e2a Mon Sep 17 00:00:00 2001 From: Vladimir Rutsky Date: Mon, 5 Oct 2015 22:52:58 +0300 Subject: [PATCH 2/2] remove "nonemptystring" and add comment instead --- .travis.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 971fc52c192..7f534572ed5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -31,7 +31,9 @@ script: env: matrix: - - PYTHONASYNCIODEBUG=nonemptystring AIOHTTP_NO_EXTENSIONS= - - PYTHONASYNCIODEBUG= AIOHTTP_NO_EXTENSIONS= - - PYTHONASYNCIODEBUG=nonemptystring AIOHTTP_NO_EXTENSIONS=nonemptystring - - PYTHONASYNCIODEBUG= AIOHTTP_NO_EXTENSIONS=nonemptystring + # PYTHONASYNCIODEBUG and AIOHTTP_NO_EXTENSIONS environment variables + # are considered as enabled if they are any non empty strings. + - PYTHONASYNCIODEBUG=X AIOHTTP_NO_EXTENSIONS= + - PYTHONASYNCIODEBUG= AIOHTTP_NO_EXTENSIONS= + - PYTHONASYNCIODEBUG=X AIOHTTP_NO_EXTENSIONS=X + - PYTHONASYNCIODEBUG= AIOHTTP_NO_EXTENSIONS=X