Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler hang when pending limit is reached #135

Merged
merged 8 commits into from
Sep 22, 2022

Conversation

pollydrag
Copy link
Collaborator

@pollydrag pollydrag commented Nov 1, 2019

What do these changes do?

Do not add job to _jobs list while waiting for a free slot in the pending queue.

Related issue number

#97, #98

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #135 (f56e16c) into master (041945f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f56e16c differs from pull request most recent head 91cb325. Consider uploading reports for the commit 91cb325 to get more accurate results

@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          231       246   +15     
=========================================
+ Hits           231       246   +15     
Impacted Files Coverage Δ
aiojobs/_scheduler.py 100.00% <100.00%> (ø)
aiojobs/_job.py 100.00% <0.00%> (ø)
aiojobs/aiohttp.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tinche
Copy link

Tinche commented Dec 15, 2019

We might be hitting this in production.

@oleynikandrey
Copy link
Contributor

Is there any plans to merge this PR?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NotoriousRebel
Copy link

@pollydrag Any updates?

@pollydrag
Copy link
Collaborator Author

@asvetlov Can you review this, please?

@simon-liebehenschel
Copy link

Hi guys, does anybody have a maintained fork of this repository? It may be great to have a maintained fork.

@simon-liebehenschel
Copy link

@hlecnt and other people:

As long as the package is abandoned, I will maintain a fork to help everyone keep using this package without critical bugs. This fix is available:

pip install aiojobs-fork==1.0.2

pollydrag and others added 3 commits September 22, 2022 15:33
review suggestion

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
review suggestion

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Copy link
Member

@Dreamsorcerer Dreamsorcerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on type annotations locally. So, not sure if it's easier to merge this before or after those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants