-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scheduler hang when pending limit is reached #135
Conversation
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 231 246 +15
=========================================
+ Hits 231 246 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
We might be hitting this in production. |
Is there any plans to merge this PR? |
|
@pollydrag Any updates? |
f56e16c
to
a20ddc8
Compare
@asvetlov Can you review this, please? |
Hi guys, does anybody have a maintained fork of this repository? It may be great to have a maintained fork. |
@hlecnt and other people: As long as the package is abandoned, I will maintain a fork to help everyone keep using this package without critical bugs. This fix is available:
|
review suggestion Co-authored-by: Sam Bull <aa6bs0@sambull.org>
review suggestion Co-authored-by: Sam Bull <aa6bs0@sambull.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on type annotations locally. So, not sure if it's easier to merge this before or after those changes.
What do these changes do?
Do not add job to
_jobs
list while waiting for a free slot in the pending queue.Related issue number
#97, #98
Checklist
CHANGES
folder