Tune py-3.14 version #528
Merged
Tune py-3.14 version #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 8 8
Lines 1119 1119
Branches 53 53
=======================================
Hits 1089 1089
Misses 18 18
Partials 12 12 ☔ View full report in Codecov by Sentry. |
| @@ -14,5 +14,6 @@ asyncio_mode = auto | |||
| asyncio_default_fixture_loop_scope = function | |||
| filterwarnings = | |||
| error | |||
| ignore:'asyncio.iscoroutinefunction' is deprecated:DeprecationWarning:aiohttp | |||
There was a problem hiding this comment.
Shouldn't we just fix this one?
Looks like it should be changed to inspect.iscoroutinefunction().
There was a problem hiding this comment.
Yes, we should fix it in aiohttp and temporarily ignore it for aiojobs.
I have a plan to enable py3.14 alpha for aiohttp and see how it is going.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the latest available 3.14.0-alpha2