Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate towncrier for the changelog generation #381

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 6, 2019

Make it mimic the approach used by aiohttp and others.

P.S.
CI will be tuned later.

@@ -0,0 +1,36 @@
{# TOWNCRIER TEMPLATE #}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this folder also needs a separate README explaining what to do. GitHub will then render it in the directory view.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good; the README is not mandatory though.
aiohttp doesn't have it; we have instructions in CONTRIBUTING document.
I think it can work for multidict as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add README here -- you are welcome. In a separate PR.

@webknjaz webknjaz changed the title Refactor changelog Integrate towncrier for the changelog generation Nov 6, 2019
pyproject.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files          10       10           
  Lines         938      938           
=======================================
  Hits          877      877           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7bb98...874c493. Read the comment docs.

@rtd-helper
Copy link

rtd-helper bot commented Nov 7, 2019

😭 Failed to visit version page at https://readthedocs.org/dashboard/multidict/version/refactor-changelog/. Please make sure you have enabled GitHub integration in your RTD project.

@asvetlov asvetlov merged commit 53ad5db into master Nov 7, 2019
@asvetlov asvetlov deleted the refactor-changelog branch November 7, 2019 22:07
@rtd-helper
Copy link

rtd-helper bot commented Nov 7, 2019

Failed to launch chrome!
[1107/222437.450896:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.450948:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.451180:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.451281:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.451321:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.451613:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.452269:ERROR:platform_thread_posix.cc(129)] pthread_create: Resource temporarily unavailable (11)
[1107/222437.451646:FATAL:simple_thread.cc(55)] Check failed: success.
#0 0x5567a57cee29 base::debug::CollectStackTrace()
#1 0x5567a5732ee3 base::debug::StackTrace::StackTrace()
#2 0x5567a57476b3 logging::LogMessage::~LogMessage()
#3 0x5567a57a130d base::SimpleThread::StartAsync()
#4 0x5567a41088f7 content::VizProcessTransportFactory::VizProcessTransportFactory()
#5 0x5567a3c1a7f4 content::BrowserMainLoop::BrowserThreadsStarted()
#6 0x5567a4013873 content::StartupTaskRunner::RunAllTasksNow()
#7 0x5567a3c1a1c2 content::BrowserMainLoop::CreateStartupTasks()
#8 0x5567a3c1cf72 content::BrowserMainRunnerImpl::Initialize()
#9 0x5567a9e0c970 headless::HeadlessContentMainDelegate::RunProcess()
#10 0x5567a536e4ff content::ContentMainRunnerImpl::RunServiceManager()
#11 0x5567a536e236 content::ContentMainRunnerImpl::Run()
#12 0x5567a53baacd service_manager::Main()
#13 0x5567a536c541 content::ContentMain()
#14 0x5567a53b99dd headless::(anonymous namespace)::RunContentMain()
#15 0x5567a53b973b headless::HeadlessShellMain()
#16 0x5567a307e218 ChromeMain
#17 0x7f72a635ab97 __libc_start_main
#18 0x5567a307e0aa _start

Received signal 6
#0 0x5567a57cee29 base::debug::CollectStackTrace()
#1 0x5567a5732ee3 base::debug::StackTrace::StackTrace()
#2 0x5567a57ce9b1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f72ac3cb890
#4 0x7f72a6377e97 gsignal
#5 0x7f72a6379801 abort
#6 0x5567a57cd815 base::debug::BreakDebugger()
#7 0x5567a5747af9 logging::LogMessage::~LogMessage()
#8 0x5567a57a130d base::SimpleThread::StartAsync()
#9 0x5567a41088f7 content::VizProcessTransportFactory::VizProcessTransportFactory()
#10 0x5567a3c1a7f4 content::BrowserMainLoop::BrowserThreadsStarted()
#11 0x5567a4013873 content::StartupTaskRunner::RunAllTasksNow()
#12 0x5567a3c1a1c2 content::BrowserMainLoop::CreateStartupTasks()
#13 0x5567a3c1cf72 content::BrowserMainRunnerImpl::Initialize()
#14 0x5567a9e0c970 headless::HeadlessContentMainDelegate::RunProcess()
#15 0x5567a536e4ff content::ContentMainRunnerImpl::RunServiceManager()
#16 0x5567a536e236 content::ContentMainRunnerImpl::Run()
#17 0x5567a53baacd service_manager::Main()
#18 0x5567a536c541 content::ContentMain()
#19 0x5567a53b99dd headless::(anonymous namespace)::RunContentMain()
#20 0x5567a53b973b headless::HeadlessShellMain()
#21 0x5567a307e218 ChromeMain
#22 0x7f72a635ab97 __libc_start_main
#23 0x5567a307e0aa _start
r8: 0000000000000000 r9: 00007ffc4920a180 r10: 0000000000000008 r11: 0000000000000246
r12: 00007ffc4920b448 r13: 00007ffc4920a428 r14: 00007ffc4920b450 r15: 00007ffc4920a440
di: 0000000000000002 si: 00007ffc4920a180 bp: 00007ffc4920a3d0 bx: 00007ffc4920a428
dx: 0000000000000000 ax: 0000000000000000 cx: 00007f72a6377e97 sp: 00007ffc4920a180
ip: 00007f72a6377e97 efl: 0000000000000246 cgf: 0000000000000033 erf: 0000000000000000
trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.

TROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md

@asvetlov
Copy link
Member Author

asvetlov commented Nov 8, 2019

@webknjaz what are the rtd comments?
Why they are here? And why is this crappy stacktrace from chrome?

@webknjaz
Copy link
Member

webknjaz commented Nov 9, 2019

@asvetlov probably because you forgot to add rtd-bot to the RTD project as a maintainer. This is an integration that shows previews of docs changes for PRs.

@asvetlov
Copy link
Member Author

asvetlov commented Nov 9, 2019

I did not add this bot to the project; I have no idea what is the bot for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants