-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate towncrier for the changelog generation #381
Conversation
@@ -0,0 +1,36 @@ | |||
{# TOWNCRIER TEMPLATE #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this folder also needs a separate README explaining what to do. GitHub will then render it in the directory view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is good; the README is not mandatory though.
aiohttp doesn't have it; we have instructions in CONTRIBUTING document.
I think it can work for multidict as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw it work here well: https://github.com/tox-dev/tox/tree/master/docs/changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to add README here -- you are welcome. In a separate PR.
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 10 10
Lines 938 938
=======================================
Hits 877 877
Misses 61 61 Continue to review full report at Codecov.
|
😭 Failed to visit version page at https://readthedocs.org/dashboard/multidict/version/refactor-changelog/. Please make sure you have enabled GitHub integration in your RTD project. |
Failed to launch chrome! Received signal 6 TROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md |
@webknjaz what are the |
@asvetlov probably because you forgot to add |
I did not add this bot to the project; I have no idea what is the bot for |
Make it mimic the approach used by aiohttp and others.
P.S.
CI will be tuned later.