Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint v4 support #1447

Closed
6 tasks done
ljharb opened this issue Jun 12, 2017 · 36 comments · Fixed by microsoftgraph/nodejs-webhooks-sample#10
Closed
6 tasks done

eslint v4 support #1447

ljharb opened this issue Jun 12, 2017 · 36 comments · Fixed by microsoftgraph/nodejs-webhooks-sample#10
Assignees
@ljharb
Labels
question

Comments

@ljharb
Copy link
Collaborator

ljharb commented Jun 12, 2017 •
edited
Loading

Note: I filed this issue within minutes of eslint v4.0.0 being released.

eslint-config-airbnb and eslint-config-airbnb-base do not yet support eslint v4.

If it is easy/possible to support both v3 and v4, we will release a non-major bump of both packages that does so, before releasing a major bump that only supports v4.

This will likely take a few weeks at a minimum.

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v3 until such time as our configs support v4.

Peer Dep eslint combined v3 and v4 support released:

  • eslint-plugin-import issue | PR | released as v2.6.0
  • eslint-plugin-react issue for v7.1.0 release
  • eslint-plugin-jsx-a11y issue | PR | release (v5.1.0 and v6)
  • eslint-find-rules issue | released as v30.1
  • update and publish the base config
  • update and publish the main config
@ljharb ljharb self-assigned this Jun 12, 2017
@alrra alrra mentioned this issue Jun 12, 2017
Closed
@eliperelman eliperelman mentioned this issue Jun 12, 2017
Closed
4 tasks
@sompylasar sompylasar mentioned this issue Jun 12, 2017
Closed
@metacortex metacortex mentioned this issue Jun 14, 2017
Closed
@ljharb ljharb mentioned this issue Jun 14, 2017
Closed
@char0n char0n mentioned this issue Jun 14, 2017
Closed
@Geczy Geczy mentioned this issue Jun 14, 2017
Closed
@ricardograca ricardograca mentioned this issue Jun 15, 2017
Merged
@ljharb ljharb mentioned this issue Jun 16, 2017
Open
@hongbo-miao hongbo-miao mentioned this issue Jun 16, 2017
Merged
@airbnb airbnb deleted a comment from willin Jun 17, 2017
@achavez achavez mentioned this issue Jun 19, 2017
Closed
@pfulton pfulton mentioned this issue Jun 19, 2017
Closed
@kevinji kevinji mentioned this issue Jun 20, 2017
Merged
@lau32 lau32 mentioned this issue Jun 20, 2017
Closed
leebenson added a commit to reactql/kit that referenced this issue Jun 20, 2017
@leebenson
1.10.0
9c2c3eb 
1.10.0 - 2017-06-20
------------------------------------------------

## ESLint
* Reverts to ESLint v3.19.0 pending
airbnb/javascript#1447
@popomore popomore mentioned this issue Jun 23, 2017
Closed
3 tasks
@NiGhTTraX NiGhTTraX mentioned this issue Jun 24, 2017
Closed
@KleoPetroff KleoPetroff mentioned this issue Jun 24, 2017
Closed
@Arcanemagus Arcanemagus mentioned this issue Jun 24, 2017
Merged
@ybiquitous ybiquitous mentioned this issue Jun 26, 2017
Closed
@larixer larixer mentioned this issue Jun 27, 2017
Closed
@Geczy
Copy link

Geczy commented Jun 28, 2017

Any updates to this?

@langpavel langpavel mentioned this issue Jun 28, 2017
Merged
@ljharb
Copy link
Collaborator Author

ljharb commented Jun 28, 2017

@Geczy I've kept the OP updated; if there's updates, you'd see them here.

Since there are no updates posted, no, there are no updates. Please be patient - the OP said "a few weeks at minimum" and it's not yet been 3.

@thrucker thrucker mentioned this issue Jun 30, 2017
Closed
@balciseri balciseri mentioned this issue Jul 2, 2017
Closed
@matteocng matteocng mentioned this issue Jul 2, 2017
Closed
@ljharb
Copy link
Collaborator Author

ljharb commented Jul 20, 2017

@arizzitano that can be ignored in eslint v4.2.0+, and will be fixed in the next release of eslint-config-airbnb-base.

@Arcanemagus Arcanemagus mentioned this issue Jul 21, 2017
Closed
ljharb added a commit that referenced this issue Jul 23, 2017
@ljharb
[Deps] allow eslint v3 or v4; update eslint-plugin-import
8113927 
Part of #1447.
@Sly777 Sly777 mentioned this issue Jul 23, 2017
Closed
@ljharb ljharb closed this as completed in 16c73d0 Jul 24, 2017
@ljharb
Copy link
Collaborator Author

ljharb commented Jul 24, 2017 •
edited
Loading

eslint-config-airbnb-base v11.3.0 has been released, which supports both eslint v3 and v4. When v12.0.0 is released, it will drop support for eslint v3, and enable a number of new rules added in v4.

eslint-config-airbnb is now released as v15.1.0. When v16.0.0 is released, it will drop support for eslint v3, upgrade eslint-plugin-jsx-a11y to v6 (#1482), and enable a number of new rules added in eslint v4 and eslint-plugin-jsx-a11y v6, as well as a number of semver-major outstanding PRs and TODOs.

(tweet)

@ljharb ljharb mentioned this issue Jul 24, 2017
Closed
@kelset kelset mentioned this issue Jul 24, 2017
Closed
@mark007
Copy link

mark007 commented Jul 24, 2017 •
edited
Loading

@ljharb Hi, this error still occurs when extending from airbnb/legacy. Is this the intention or should it also be updated to remove the top level ecmaFeatures?

@shaharmor
Copy link

@ljharb airbnb/legacy has some issues with v4 still

@dirk-thomas dirk-thomas mentioned this issue Jul 24, 2017
Merged
@ljharb
Copy link
Collaborator Author

ljharb commented Jul 24, 2017

Thanks, legacy is fixed in 0d938ae and will be released in eslint-config-airbnb-base shortly.

@muffinresearch muffinresearch mentioned this issue Jul 26, 2017
Merged
jcane86 added a commit to jcane86/motor-hat that referenced this issue Aug 9, 2017
@jcane86
chore(package): update eslint-config-airbnb-base to 11.3.0
66c6d57 
See airbnb/javascript#1447
Closes #17
jcane86 added a commit to jcane86/motor-hat that referenced this issue Aug 9, 2017
@jcane86
chore(package): update eslint-config-airbnb-base to 11.3.0
ed41e79 
See airbnb/javascript#1447
Closes #17
@wkurniawan07
Copy link

Hi, any updates on when the ESLint v4-exclusive versions (v12.0.0 base and v16.0.0 main) will be released? Thanks for all the awesome works!

@ljharb
Copy link
Collaborator Author

ljharb commented Aug 13, 2017

No updates.

@1000miles 1000miles mentioned this issue Aug 24, 2017
Closed
@mark007
Copy link

mark007 commented Aug 29, 2017

@ljharb is there any version of eslint-config-airbnb that includes the fix for the legacy.js file when introducing eslint v4, ie this patch 0d938ae

I don't think its included in the latest 15.1.0 of eslint-config-airbnb that I can see?

@ljharb
Copy link
Collaborator Author

ljharb commented Aug 29, 2017

It's automatically included because of the semver range on eslint-config-airbnb-base.

jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this issue Sep 19, 2017
@ljharb @jaylaw81
[Deps] allow eslint v3 or v4; update eslint-plugin-import
b0292b9 
Part of airbnb#1447.
jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this issue Sep 19, 2017
@ljharb @jaylaw81
[eslint config] [deps] allow eslint v3 or v4
5add189 
Closes airbnb#1447.
@verekia verekia mentioned this issue Sep 27, 2017
Closed
@ljharb
Copy link
Collaborator Author

ljharb commented Oct 6, 2017

v16 is now released.

@ljharb ljharb mentioned this issue Jun 21, 2018
Closed
21 tasks
@ljharb ljharb mentioned this issue May 11, 2019
Closed
17 tasks
@ljharb ljharb mentioned this issue May 7, 2020
Closed
19 tasks
@ljharb ljharb mentioned this issue Oct 9, 2021
Closed
22 tasks
@ljharb ljharb mentioned this issue Apr 6, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljharb ljharb

Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update packages