Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): Set font color for inverted tooltip #388

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

Xapphire13
Copy link
Contributor

@Xapphire13 Xapphire13 commented Jul 2, 2020

to: @williaster @alecklandgraf

Description

Turns out when I made my previous change #386, I didnt account for the fact that the text would always be the default color (which works well against color.base, but not so well for color.baseInverted).

Since the background will be baseInverted, this change sets the foreground color to base which, by definition will be contrasting

Motivation and Context

See above

Testing

  • Storybook

Screenshots

No visual change for this project, it seems that the colors work well in lunar's storybook, but not for other projects like Nova.

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 566.49 KB 566.47 KB 708.54 KB 708.52 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580066,
    "lib": 725521
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 580089,
    "lib": 725544
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@Xapphire13 Xapphire13 changed the title update(tooltip): Set font color for inverted tooltip fix(tooltip): Set font color for inverted tooltip Jul 2, 2020
@Xapphire13 Xapphire13 merged commit 0c57553 into master Jul 2, 2020
@Xapphire13 Xapphire13 deleted the shc-tooltip-inverted branch July 2, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants