fix(tooltip): Set font color for inverted tooltip #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @williaster @alecklandgraf
Description
Turns out when I made my previous change #386, I didnt account for the fact that the text would always be the default color (which works well against
color.base
, but not so well forcolor.baseInverted
).Since the background will be
baseInverted
, this change sets the foreground color tobase
which, by definition will be contrastingMotivation and Context
See above
Testing
Screenshots
No visual change for this project, it seems that the colors work well in lunar's storybook, but not for other projects like Nova.
Checklist