Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(RotateControls, ZoomControls): Add icon size prop #381

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

al-chen
Copy link
Contributor

@al-chen al-chen commented Jun 18, 2020

to: @williaster @hayes @alecklandgraf

Description

title and diff should be explanatory

Motivation and Context

Design calls for icon sizes to be modifiable - the <RotateControls /> and <ZoomControls /> components almost always accompany <ImageViewer />, and if <ImageViewer /> height/width can be changed via props, then naturally the controls should be too for extensibility.

Testing

Updated tests to include size prop.

Screenshots

n/a

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

airbnb-bot commented Jun 18, 2020

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 566.39 KB 566.23 KB 708.44 KB 708.19 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 579823,
    "lib": 725188
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 579985,
    "lib": 725440
  },
  "forms": {
    "esm": 37350,
    "lib": 49298
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any idea what the happo diff is about? (change in emoji 🤔 )

my only thought is that iconSize might be a little more clear than size, but the latter is prob fine.

@al-chen al-chen force-pushed the achen-rotate-zoom-icon-sizes branch from 956366b to 9b22285 Compare June 30, 2020 23:55
@al-chen
Copy link
Contributor Author

al-chen commented Jul 1, 2020

Dunno why I'm getting happo diff - last time it was on emojis, this time on Autocomplete - is it flaky/should I run it again?

Either way, this change is otherwise ready to go. cc @williaster

@williaster
Copy link
Contributor

@al-chen the emoji diffs came up on another PR yesterday (I think it was a chrome font rendering thing) which was merged so that's prob why they went away.

No idea what the Autocomplete issue is here 🤔 I think we should just land this.

@williaster williaster merged commit 79d0866 into master Jul 1, 2020
@williaster williaster deleted the achen-rotate-zoom-icon-sizes branch July 1, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants