update(RotateControls, ZoomControls): Add icon size prop #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @williaster @hayes @alecklandgraf
Description
title and diff should be explanatory
Motivation and Context
Design calls for icon sizes to be modifiable - the
<RotateControls />
and<ZoomControls />
components almost always accompany<ImageViewer />
, and if<ImageViewer />
height/width can be changed via props, then naturally the controls should be too for extensibility.Testing
Updated tests to include size prop.
Screenshots
n/a
Checklist