From 47a1b380cc4795455f71cac5dc6522510a3e81cf Mon Sep 17 00:00:00 2001 From: Mathieu Dutour Date: Sun, 1 Dec 2019 22:24:24 +0100 Subject: [PATCH 1/4] add proper types for js-sha --- src/types/js-sha1.d.ts | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/types/js-sha1.d.ts b/src/types/js-sha1.d.ts index b6d869a1..2999fc87 100644 --- a/src/types/js-sha1.d.ts +++ b/src/types/js-sha1.d.ts @@ -1 +1,13 @@ -declare module 'js-sha1'; +declare module 'js-sha1' { + function sha1(dest: string | Array | ArrayBuffer | Uint8Array): string; + + namespace sha1 { + export function hex(arg: string): string; + export function update(arg: string | Array | Uint8Array | ArrayBuffer): string; + export function array(): Uint8Array; + export function digest(): Uint8Array; + export function arrayBuffer(): ArrayBuffer; + } + + export = sha1; +} From b70a148349733346cafa916d55895030e8ab2a2d Mon Sep 17 00:00:00 2001 From: Mathieu Dutour Date: Sun, 1 Dec 2019 22:24:38 +0100 Subject: [PATCH 2/4] fix import for js-sha1 --- src/utils/getImageDataFromURL.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/getImageDataFromURL.ts b/src/utils/getImageDataFromURL.ts index ae6734de..e7b19312 100644 --- a/src/utils/getImageDataFromURL.ts +++ b/src/utils/getImageDataFromURL.ts @@ -8,7 +8,7 @@ const makeImageDataFromUrl = (url?: string): { data: string; sha1: string } => { return { data, - sha1: sha1.default(data), + sha1: sha1(data), }; }; From 8ecd9c95b93f28c34d63783df6b9c312c99fa3ae Mon Sep 17 00:00:00 2001 From: Mathieu Dutour Date: Sun, 1 Dec 2019 22:24:44 +0100 Subject: [PATCH 3/4] better types --- src/jsonUtils/nodeImpl/makeImageDataFromUrl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jsonUtils/nodeImpl/makeImageDataFromUrl.ts b/src/jsonUtils/nodeImpl/makeImageDataFromUrl.ts index d5e3b5a6..7cfeb6ea 100644 --- a/src/jsonUtils/nodeImpl/makeImageDataFromUrl.ts +++ b/src/jsonUtils/nodeImpl/makeImageDataFromUrl.ts @@ -1,5 +1,5 @@ import requireObjCBridge from './requireObjCBridge'; -export default function makeImageDataFromUrl(url?: string) { +export default function makeImageDataFromUrl(url?: string): string { return requireObjCBridge().makeImageDataFromUrl(url); } From 3417c7710ae486b5e0326a80c93f914bfc9fc597 Mon Sep 17 00:00:00 2001 From: Mathieu Dutour Date: Sun, 1 Dec 2019 22:24:52 +0100 Subject: [PATCH 4/4] v3.0.3 --- CHANGELOG.md | 5 +++++ package.json | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7db375e5..386fe920 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ This project adheres to [Semantic Versioning](http://semver.org/). Every release, along with the migration instructions, is documented on the Github [Releases](https://github.com/airbnb/react-sketchapp/releases) page. +## Version 3.0.3 + +- Fix typo in Symbol (Thanks @antoni!) +- Fix messed up `js-sha` import (#456) + ## Version 3.0.2 - Fix rotation direction (#433) diff --git a/package.json b/package.json index ac3f03f4..25e8df6f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-sketchapp", - "version": "3.0.2", + "version": "3.0.3", "description": "A React renderer for Sketch.app", "main": "lib/index.js", "types": "lib/index.d.ts",