fix: handle null values in time-series table (apache#18039)

airbnb · Jan 14, 2022 · 26dc600 · 26dc600
1 parent 343d3f8
commit 26dc600
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/superset-frontend/src/visualizations/TimeTable/TimeTable.jsx b/superset-frontend/src/visualizations/TimeTable/TimeTable.jsx
@@ -192,14 +192,17 @@ const TimeTable = ({
         } else {
           v = reversedEntries[timeLag][valueField];
         }
-        if (column.comparisonType === 'diff') {
-          v = recent - v;
-        } else if (column.comparisonType === 'perc') {
-          v = recent / v;
-        } else if (column.comparisonType === 'perc_change') {
-          v = recent / v - 1;
+        if (typeof v === 'number' || typeof recent === 'number') {
+          if (column.comparisonType === 'diff') {
+            v = recent - v;
+          } else if (column.comparisonType === 'perc') {
+            v = recent / v;
+          } else if (column.comparisonType === 'perc_change') {
+            v = recent / v - 1;
+          }
+        } else {
+          v = 'N/A';
         }
-        v = v || 0;
       } else if (column.colType === 'contrib') {
         // contribution to column total
         v =