From 39402c1664ae88f33f273e631388f3a6b6ae35cf Mon Sep 17 00:00:00 2001 From: "Claudio F. Viera M" Date: Thu, 9 Feb 2023 19:43:39 -0300 Subject: [PATCH] Helm: set new attribute (#22114) * set new helm attribute * change to camelCase --------- Co-authored-by: Kyryl Skobylko Co-authored-by: Marcos Marx --- charts/airbyte/templates/env-configmap.yaml | 10 +++++----- charts/airbyte/values.yaml | 8 ++++++++ charts/airbyte/values.yaml.test | 7 +++++++ 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/charts/airbyte/templates/env-configmap.yaml b/charts/airbyte/templates/env-configmap.yaml index f55fd2e88e8b..c47545808815 100644 --- a/charts/airbyte/templates/env-configmap.yaml +++ b/charts/airbyte/templates/env-configmap.yaml @@ -42,7 +42,7 @@ data: {{- end }} JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: "0.29.15.001" LOCAL_ROOT: /tmp/airbyte_local - RUN_DATABASE_MIGRATION_ON_STARTUP: "true" + RUN_DATABASE_MIGRATION_ON_STARTUP: {{ .Values.airbyte-bootloader.runDatabaseMigrationsOnStartup | default "true" }} S3_LOG_BUCKET: {{ .Values.global.logs.s3.bucket | quote }} S3_LOG_BUCKET_REGION: {{ .Values.global.logs.s3.bucketRegion | quote }} S3_MINIO_ENDPOINT: {{ include "airbyte.minio.endpoint" . | quote }} @@ -58,9 +58,9 @@ data: WORKSPACE_ROOT: /workspace METRIC_CLIENT: {{ .Values.global.metrics.metricClient | default "" | quote }} OTEL_COLLECTOR_ENDPOINT: {{ .Values.global.metrics.otelCollectorEndpoint | default "" | quote }} - ACTIVITY_MAX_ATTEMPT: "" - ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: "" - ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: "" + ACTIVITY_MAX_ATTEMPT: {{ .Values.worker.activityMaxAttempt | default "" }} + ACTIVITY_INITIAL_DELAY_BETWEEN_ATTEMPTS_SECONDS: {{ .Values.worker.activityInitialDelayBetweenAttemptsSeconds | default "" }} + ACTIVITY_MAX_DELAY_BETWEEN_ATTEMPTS_SECONDS: {{ .Values.worker.activityMaxDelayBetweenAttemptsSeconds | default "" }} WORKFLOW_FAILURE_RESTART_DELAY_SECONDS: "" USE_STREAM_CAPABLE_STATE: "true" AUTO_DETECT_SCHEMA: "true" @@ -71,5 +71,5 @@ data: WORKER_LOGS_STORAGE_TYPE: {{ .Values.global.logs.storage.type | quote }} WORKER_STATE_STORAGE_TYPE: {{ .Values.global.state.storage.type | quote }} SHOULD_RUN_NOTIFY_WORKFLOWS: "false" - MAX_NOTIFY_WORKERS: "5" + MAX_NOTIFY_WORKERS: {{ .Values.worker.maxNotifyWorkers | default "5" }} {{- end }} diff --git a/charts/airbyte/values.yaml b/charts/airbyte/values.yaml index 4cfcc78965d8..c1450520fa73 100644 --- a/charts/airbyte/values.yaml +++ b/charts/airbyte/values.yaml @@ -819,6 +819,11 @@ worker: enabled: true image: "" + ## current no exist documentations + activityMaxAttempt: "" + activityInitialDelayBetweenAttemptsSeconds: "" + activityMaxDelayBetweenAttemptsSeconds: "" + ## @section Metrics parameters metrics: enabled: false @@ -1057,6 +1062,9 @@ airbyte-bootloader: ## extraVolumes: [] + ## run database migrations on startup true|false + runDatabaseMigrationsOnStartup: "true" + ## @section Temporal parameters ## TODO: Move to consuming temporal from a dedicated helm chart diff --git a/charts/airbyte/values.yaml.test b/charts/airbyte/values.yaml.test index 1708bbcac985..54c0e35765f2 100644 --- a/charts/airbyte/values.yaml.test +++ b/charts/airbyte/values.yaml.test @@ -807,6 +807,10 @@ worker: enabled: true image: "" + activityMaxAttempt: "" + activityInitialDelayBetweenAttemptsSeconds: "" + activityMaxDelayBetweenAttemptsSeconds: "" + ## @section Metrics parameters metrics: enabled: false @@ -1045,6 +1049,9 @@ airbyte-bootloader: ## extraVolumes: [] + ## run database migrations on startup true|false + runDatabaseMigrationsOnStartup: "true" + ## @section Temporal parameters ## TODO: Move to consuming temporal from a dedicated helm chart