From 742a52bbac632c77a8080b8c2c7b902ec824254c Mon Sep 17 00:00:00 2001 From: Marcos Marx Date: Thu, 16 Mar 2023 16:43:22 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20=F0=9F=9A=A8=F0=9F=9A=A8=20Sourc?= =?UTF-8?q?e=20LinkedIn=20Pages:=20fixed=20failing=20connection=20checks?= =?UTF-8?q?=20(#24161)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fixed issue with the org id not being an integer and deleted duplicate streams * bumped version to 0.1.1 * Update source_definitions.yaml * Update acceptance-test-config.yml * Update linkedin-pages.md * black formatting for python * fix tests * update acceptance test file * change break spec - backward compt. * fix changelog * auto-bump connector version --------- Co-authored-by: Tino Merl Co-authored-by: Vincent Koc Co-authored-by: Vincent Koc <25068+koconder@users.noreply.github.com> Co-authored-by: Sajarin Co-authored-by: Octavia Squidington III --- .../resources/seed/source_definitions.yaml | 2 +- .../src/main/resources/seed/source_specs.yaml | 4 +-- .../source-linkedin-pages/Dockerfile | 2 +- .../acceptance-test-config.yml | 32 ++++++++++++------- .../integration_tests/invalid_config.json | 2 +- .../integration_tests/sample_config.json | 2 +- .../source_linkedin_pages/spec.json | 2 +- connectors.md | 2 +- docs/integrations/sources/linkedin-pages.md | 1 + 9 files changed, 30 insertions(+), 19 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index b28c336d408f..8c64acb72276 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -1077,7 +1077,7 @@ - name: LinkedIn Pages sourceDefinitionId: af54297c-e8f8-4d63-a00d-a94695acc9d3 dockerRepository: airbyte/source-linkedin-pages - dockerImageTag: 0.1.0 + dockerImageTag: 1.0.0 documentationUrl: https://docs.airbyte.com/integrations/sources/linkedin-pages icon: linkedin.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index fa2a479a64a8..f3aac1d00dd8 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -7894,7 +7894,7 @@ - - "client_secret" oauthFlowOutputParameters: - - "refresh_token" -- dockerImage: "airbyte/source-linkedin-pages:0.1.0" +- dockerImage: "airbyte/source-linkedin-pages:1.0.0" spec: documentationUrl: "https://docs.airbyte.com/integrations/sources/linkedin-pages/" connectionSpecification: @@ -7907,7 +7907,7 @@ properties: org_id: title: "Organization ID" - type: "integer" + type: "string" airbyte_secret: true description: "Specify the Organization ID" examples: diff --git a/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile b/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile index 926f0c238fb0..ff17f19c5d99 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile +++ b/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile @@ -34,5 +34,5 @@ COPY source_linkedin_pages ./source_linkedin_pages ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.0 +LABEL io.airbyte.version=1.0.0 LABEL io.airbyte.name=airbyte/source-linkedin-pages diff --git a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml index fed4008bca10..535ba5a47283 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml @@ -1,19 +1,29 @@ # See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) # for more information about how to configure these tests connector_image: airbyte/source-linkedin-pages:dev -tests: +test_strictness_level: low +acceptance_tests: spec: - - spec_path: "source_linkedin_pages/spec.json" + tests: + - spec_path: "source_linkedin_pages/spec.json" + backward_compatibility_tests_config: + disable_for_version: "0.1.0" connection: - - config_path: "secrets/config.json" - status: "succeed" - - config_path: "integration_tests/invalid_config.json" - status: "failed" + tests: + - config_path: "secrets/config.json" + status: "succeed" + - config_path: "integration_tests/invalid_config.json" + status: "failed" discovery: - - config_path: "secrets/config.json" + tests: + - config_path: "secrets/config.json" + backward_compatibility_tests_config: + disable_for_version: "0.1.0" basic_read: - - config_path: "secrets/config.json" - configured_catalog_path: "integration_tests/configured_catalog.json" + tests: + - config_path: "secrets/config.json" + configured_catalog_path: "integration_tests/configured_catalog.json" full_refresh: - - config_path: "secrets/config.json" - configured_catalog_path: "integration_tests/configured_catalog.json" + tests: + - config_path: "secrets/config.json" + configured_catalog_path: "integration_tests/configured_catalog.json" diff --git a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json index fd62f7bf71a6..a0fa475e00a5 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json +++ b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json @@ -1,5 +1,5 @@ { - "org_id": 12345678, + "org_id": "12345678", "credentials": { "auth_method": "access_token", "access_token": "wrong_token_sra6ibiw0ZWEdMnC0ZizeD1gLRQP6u1pkQl" diff --git a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json index c32e7dbe2010..7399ec4e7981 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json +++ b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json @@ -1,5 +1,5 @@ { - "org_id": 12345678, + "org_id": "12345678", "credentials": { "auth_method": "access_token", "access_token": "example_token_string123" diff --git a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json index ba4b533c5782..abd9d54b35d6 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json +++ b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json @@ -9,7 +9,7 @@ "properties": { "org_id": { "title": "Organization ID", - "type": "integer", + "type": "string", "airbyte_secret": true, "description": "Specify the Organization ID", "examples": ["123456789"] diff --git a/connectors.md b/connectors.md index 5be4ddf78879..46272b0c4ec6 100644 --- a/connectors.md +++ b/connectors.md @@ -124,7 +124,7 @@ | **Lemlist** | x | Source | airbyte/source-lemlist:0.1.1 | alpha | [link](https://docs.airbyte.com/integrations/sources/lemlist) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lemlist) | `789f8e7a-2d28-11ec-8d3d-0242ac130003` | | **Lever Hiring** | Lever Hiring icon | Source | airbyte/source-lever-hiring:0.1.3 | alpha | [link](https://docs.airbyte.com/integrations/sources/lever-hiring) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lever-hiring) | `3981c999-bd7d-4afc-849b-e53dea90c948` | | **LinkedIn Ads** | LinkedIn Ads icon | Source | airbyte/source-linkedin-ads:0.1.15 | generally_available | [link](https://docs.airbyte.com/integrations/sources/linkedin-ads) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-ads) | `137ece28-5434-455c-8f34-69dc3782f451` | -| **LinkedIn Pages** | LinkedIn Pages icon | Source | airbyte/source-linkedin-pages:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/linkedin-pages) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-pages) | `af54297c-e8f8-4d63-a00d-a94695acc9d3` | +| **LinkedIn Pages** | LinkedIn Pages icon | Source | airbyte/source-linkedin-pages:1.0.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/linkedin-pages) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-pages) | `af54297c-e8f8-4d63-a00d-a94695acc9d3` | | **Linnworks** | Linnworks icon | Source | airbyte/source-linnworks:0.1.5 | alpha | [link](https://docs.airbyte.com/integrations/sources/linnworks) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linnworks) | `7b86879e-26c5-4ef6-a5ce-2be5c7b46d1e` | | **Lokalise** | Lokalise icon | Source | airbyte/source-lokalise:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/lokalise) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lokalise) | `45e0b135-615c-40ac-b38e-e65b0944197f` | | **Looker** | Looker icon | Source | airbyte/source-looker:0.2.8 | alpha | [link](https://docs.airbyte.com/integrations/sources/looker) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-looker) | `00405b19-9768-4e0c-b1ae-9fc2ee2b2a8c` | diff --git a/docs/integrations/sources/linkedin-pages.md b/docs/integrations/sources/linkedin-pages.md index 471b040e4c9e..ab06e16ba493 100644 --- a/docs/integrations/sources/linkedin-pages.md +++ b/docs/integrations/sources/linkedin-pages.md @@ -110,4 +110,5 @@ The source LinkedIn Pages can use either the `client_id`, `client_secret` and `r | Version | Date | Pull Request | Subject | | :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------- | +| 1.0.0 | 2023-03-16 | [18967](https://github.com/airbytehq/airbyte/pull/18967) | Fixed failing connection checks | | 0.1.0 | 2022-08-11 | [13098](https://github.com/airbytehq/airbyte/pull/13098) | Initial Release |