From aeb6801683364a4d3293895f182787f9ee5a8c84 Mon Sep 17 00:00:00 2001 From: Alex Birdsall Date: Tue, 29 Nov 2022 11:48:22 -0800 Subject: [PATCH] Allow overriding cloud env in start:cloud script (#19857) Uses basic bash variable substitution syntax to define `frontend-dev` as a default value for `$AB_ENV` instead of hardcoded; tested and working in bash, zsh, and fish shells. To specify different environments: ```sh # `$AB_ENV` is the default value, `"frontend-dev"` npm run start:cloud # `$AB_ENV` is the user-supplied value, `"dev-2"`; expects a corresponding `.env.dev-2` file to exist AB_ENV=dev-2 npm run start:cloud ``` --- airbyte-webapp/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airbyte-webapp/package.json b/airbyte-webapp/package.json index 2371fde0d81b1..e392b5bf0a2eb 100644 --- a/airbyte-webapp/package.json +++ b/airbyte-webapp/package.json @@ -10,7 +10,7 @@ "prestart": "npm run generate-client", "start": "craco start", "prestart:cloud": "npm run generate-client", - "start:cloud": "AB_ENV=frontend-dev node -r ./scripts/environment.js ./node_modules/.bin/craco start", + "start:cloud": "AB_ENV=${AB_ENV-frontend-dev} node -r ./scripts/environment.js ./node_modules/.bin/craco start", "prebuild": "npm run generate-client", "build": "BUILD_PATH='./build/app' craco build", "pretest": "npm run generate-client",