From b37ba503624026fa5ad12af9781f47ffd96a8eaf Mon Sep 17 00:00:00 2001 From: Denys Davydov Date: Wed, 21 Dec 2022 21:15:25 +0200 Subject: [PATCH] #1148 source google ads - fix SATs --- .../acceptance-test-config.yml | 4 +++- .../integration_tests/abnormal_state.json | 14 +++++++++++ .../incremental_catalog.json | 24 +++++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) diff --git a/airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml b/airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml index 2a85c4f5bcf4..0aad58fbad44 100644 --- a/airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-google-ads/acceptance-test-config.yml @@ -36,7 +36,7 @@ acceptance_tests: configured_catalog_path: "integration_tests/configured_catalog.json" incremental: tests: - - config_path: "secrets/config.json" + - config_path: "secrets/incremental_config.json" configured_catalog_path: "integration_tests/incremental_catalog.json" threshold_days: 14 future_state: @@ -53,3 +53,5 @@ acceptance_tests: accounts: ["4651612872", "segments.date"] campaigns: ["4651612872", "segments.date"] user_location_report: ["4651612872", "segments.date"] + ad_group_ad_report: ["4651612872", "segments.date"] + display_keyword_performance_report: ["4651612872", "segments.date"] diff --git a/airbyte-integrations/connectors/source-google-ads/integration_tests/abnormal_state.json b/airbyte-integrations/connectors/source-google-ads/integration_tests/abnormal_state.json index eee898eb26d6..9241aad423b4 100644 --- a/airbyte-integrations/connectors/source-google-ads/integration_tests/abnormal_state.json +++ b/airbyte-integrations/connectors/source-google-ads/integration_tests/abnormal_state.json @@ -75,5 +75,19 @@ "stream_state": { "4651612872": { "segments.date": "2222-01-01" }}, "stream_descriptor": { "name": "user_location_report" } } + }, + { + "type": "STREAM", + "stream": { + "stream_state": { "4651612872": { "segments.date": "2222-01-01" }}, + "stream_descriptor": { "name": "ad_group_ad_report" } + } + }, + { + "type": "STREAM", + "stream": { + "stream_state": { "4651612872": { "segments.date": "2222-01-01" }}, + "stream_descriptor": { "name": "display_keyword_performance_report" } + } } ] diff --git a/airbyte-integrations/connectors/source-google-ads/integration_tests/incremental_catalog.json b/airbyte-integrations/connectors/source-google-ads/integration_tests/incremental_catalog.json index 836edf1ceec6..bfe6dbf07f88 100644 --- a/airbyte-integrations/connectors/source-google-ads/integration_tests/incremental_catalog.json +++ b/airbyte-integrations/connectors/source-google-ads/integration_tests/incremental_catalog.json @@ -144,6 +144,30 @@ "sync_mode": "incremental", "destination_sync_mode": "overwrite", "cursor_field": ["segments.date"] + }, + { + "stream": { + "name": "ad_group_ad_report", + "json_schema": {}, + "supported_sync_modes": ["full_refresh", "incremental"], + "source_defined_cursor": true, + "default_cursor_field": ["segments.date"] + }, + "sync_mode": "incremental", + "destination_sync_mode": "overwrite", + "cursor_field": ["segments.date"] + }, + { + "stream": { + "name": "display_keyword_performance_report", + "json_schema": {}, + "supported_sync_modes": ["full_refresh", "incremental"], + "source_defined_cursor": true, + "default_cursor_field": ["segments.date"] + }, + "sync_mode": "incremental", + "destination_sync_mode": "overwrite", + "cursor_field": ["segments.date"] } ] }