From 4770b718f7b4d4efb663d007008e20c43c5314d2 Mon Sep 17 00:00:00 2001 From: alafanechere Date: Wed, 20 Apr 2022 17:03:20 +0200 Subject: [PATCH 1/3] make acceptance tests pass --- .../connectors/source-twilio/acceptance-test-config.yml | 1 + .../connectors/source-twilio/source_twilio/schemas/calls.json | 3 +++ .../connectors/source-twilio/source_twilio/streams.py | 1 + 3 files changed, 5 insertions(+) diff --git a/airbyte-integrations/connectors/source-twilio/acceptance-test-config.yml b/airbyte-integrations/connectors/source-twilio/acceptance-test-config.yml index 6f9af98f9e0b8..656393e7b96af 100644 --- a/airbyte-integrations/connectors/source-twilio/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-twilio/acceptance-test-config.yml @@ -12,6 +12,7 @@ tests: basic_read: - config_path: "secrets/config.json" configured_catalog_path: "integration_tests/no_empty_streams_catalog.json" + empty_streams: ["message_media", "conferences"] incremental: - config_path: "secrets/config.json" # usage records stream produces and error if cursor date gte than current date diff --git a/airbyte-integrations/connectors/source-twilio/source_twilio/schemas/calls.json b/airbyte-integrations/connectors/source-twilio/source_twilio/schemas/calls.json index 3daf6f426b73b..9fd1b90e18b13 100644 --- a/airbyte-integrations/connectors/source-twilio/source_twilio/schemas/calls.json +++ b/airbyte-integrations/connectors/source-twilio/source_twilio/schemas/calls.json @@ -106,6 +106,9 @@ }, "feedback_summaries": { "type": ["null", "string"] + }, + "streams": { + "type": ["null", "string"] } } } diff --git a/airbyte-integrations/connectors/source-twilio/source_twilio/streams.py b/airbyte-integrations/connectors/source-twilio/source_twilio/streams.py index 2a937d7806950..4f5f656cb07a3 100644 --- a/airbyte-integrations/connectors/source-twilio/source_twilio/streams.py +++ b/airbyte-integrations/connectors/source-twilio/source_twilio/streams.py @@ -285,6 +285,7 @@ class ConferenceParticipants(TwilioNestedStream): which are on conference call at the moment request is made). """ + primary_key = ["account_sid", "conference_sid"] parent_stream = Conferences data_field = "participants" From b545a35c41f530bcf1e2c7619cb11f2032d57fd0 Mon Sep 17 00:00:00 2001 From: alafanechere Date: Wed, 20 Apr 2022 17:10:33 +0200 Subject: [PATCH 2/3] bump version --- airbyte-integrations/connectors/source-twilio/Dockerfile | 2 +- docs/integrations/sources/twilio.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/airbyte-integrations/connectors/source-twilio/Dockerfile b/airbyte-integrations/connectors/source-twilio/Dockerfile index f4f1212fb6b74..21d5a877a8d83 100644 --- a/airbyte-integrations/connectors/source-twilio/Dockerfile +++ b/airbyte-integrations/connectors/source-twilio/Dockerfile @@ -12,5 +12,5 @@ RUN pip install . ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.2 +LABEL io.airbyte.version=0.1.3 LABEL io.airbyte.name=airbyte/source-twilio diff --git a/docs/integrations/sources/twilio.md b/docs/integrations/sources/twilio.md index 52352eb95030a..2b1051007b4be 100644 --- a/docs/integrations/sources/twilio.md +++ b/docs/integrations/sources/twilio.md @@ -66,6 +66,7 @@ See [docs](https://www.twilio.com/docs/iam/api) for more details. | Version | Date | Pull Request | Subject | | :--- | :--- | :--- | :--- | +| 0.1.3 | 2022-04-20 | [12183](https://github.com/airbytehq/airbyte/pull/12183) | Add new subresource on the call stream + declare a valid primary key for conference_participants stream | | 0.1.2 | 2021-12-23 | [9092](https://github.com/airbytehq/airbyte/pull/9092) | Correct specification doc URL | | 0.1.1 | 2021-10-18 | [7034](https://github.com/airbytehq/airbyte/pull/7034) | Update schemas and transform data types according to the API schema | | 0.1.0 | 2021-07-02 | [4070](https://github.com/airbytehq/airbyte/pull/4070) | Native Twilio connector implemented | From dc9aec454306b1e1234da46b9f7957d902b13646 Mon Sep 17 00:00:00 2001 From: Octavia Squidington III Date: Thu, 21 Apr 2022 07:41:34 +0000 Subject: [PATCH 3/3] auto-bump connector version --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- airbyte-config/init/src/main/resources/seed/source_specs.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index a25acd0a4664b..27fe75eb2bc2f 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -806,7 +806,7 @@ - name: Twilio sourceDefinitionId: b9dc6155-672e-42ea-b10d-9f1f1fb95ab1 dockerRepository: airbyte/source-twilio - dockerImageTag: 0.1.2 + dockerImageTag: 0.1.3 documentationUrl: https://docs.airbyte.io/integrations/sources/twilio icon: twilio.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index 5d014f25fe952..c05b9a8827afe 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -8609,9 +8609,9 @@ oauthFlowOutputParameters: - - "token" - - "key" -- dockerImage: "airbyte/source-twilio:0.1.2" +- dockerImage: "airbyte/source-twilio:0.1.3" spec: - documentationUrl: "https://hub.docker.com/r/airbyte/source-twilio" + documentationUrl: "https://docs.airbyte.io/integrations/sources/twilio" connectionSpecification: $schema: "http://json-schema.org/draft-07/schema#" title: "Twilio Spec"