From f7fd31e0d7669b4032db74ab3930c679661289df Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Thu, 6 Oct 2022 17:45:04 -0300 Subject: [PATCH 1/4] solve cursor field none expected array --- airbyte-integrations/connectors/source-mixpanel/Dockerfile | 2 +- .../source-mixpanel/source_mixpanel/streams/engage.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte-integrations/connectors/source-mixpanel/Dockerfile b/airbyte-integrations/connectors/source-mixpanel/Dockerfile index 7941d35a3b90..3d23ac5d7499 100644 --- a/airbyte-integrations/connectors/source-mixpanel/Dockerfile +++ b/airbyte-integrations/connectors/source-mixpanel/Dockerfile @@ -13,5 +13,5 @@ ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.27 +LABEL io.airbyte.version=0.1.28 LABEL io.airbyte.name=airbyte/source-mixpanel diff --git a/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py b/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py index 168c2ef31502..a06c1f253853 100644 --- a/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py +++ b/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py @@ -67,7 +67,7 @@ class Engage(IncrementalMixpanelStream): primary_key: str = "distinct_id" page_size: int = 1000 # min 100 _total: Any = None - cursor_field = None + cursor_field = [] @property def source_defined_cursor(self) -> bool: From dcd9d80b7dc95bb5dbaed499c2e1153785380e19 Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Thu, 6 Oct 2022 17:48:53 -0300 Subject: [PATCH 2/4] update doc --- docs/integrations/sources/mixpanel.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/integrations/sources/mixpanel.md b/docs/integrations/sources/mixpanel.md index fd90c0dd12ae..fd48fe18feee 100644 --- a/docs/integrations/sources/mixpanel.md +++ b/docs/integrations/sources/mixpanel.md @@ -63,6 +63,7 @@ Please note, that incremental sync could return duplicated \(old records\) for t | Version | Date | Pull Request | Subject | | :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------------------------------------------------- | +| 0.1.28 | 2022-10-06 | [17699](https://github.com/airbytehq/airbyte/pull/17699) | Fix discover step issue cursor field None | | 0.1.27 | 2022-09-29 | [17415](https://github.com/airbytehq/airbyte/pull/17415) | Disable stream "cohort_members" on discover if not access | | 0.1.26 | 2022-09-28 | [17304](https://github.com/airbytehq/airbyte/pull/17304) | Migrate to per-stream states. | | 0.1.25 | 2022-09-27 | [17145](https://github.com/airbytehq/airbyte/pull/17145) | Disable streams "export", "engage" on discover if not access | From 2c1654b1e1ecf1ff8f3d51044a75a33022f996a8 Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Thu, 6 Oct 2022 20:52:37 -0300 Subject: [PATCH 3/4] correct cursor_field --- .../source-mixpanel/integration_tests/configured_catalog.json | 4 ++-- .../source-mixpanel/source_mixpanel/streams/engage.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/airbyte-integrations/connectors/source-mixpanel/integration_tests/configured_catalog.json b/airbyte-integrations/connectors/source-mixpanel/integration_tests/configured_catalog.json index 0d2eb25e3270..e8bf78c6703a 100644 --- a/airbyte-integrations/connectors/source-mixpanel/integration_tests/configured_catalog.json +++ b/airbyte-integrations/connectors/source-mixpanel/integration_tests/configured_catalog.json @@ -18,7 +18,7 @@ "json_schema": {}, "supported_sync_modes": ["full_refresh", "incremental"], "source_defined_cursor": false, - "default_cursor_field": null, + "default_cursor_field": ["last_seen"], "source_defined_primary_key": [["distinct_id"]] }, "sync_mode": "incremental", @@ -63,7 +63,7 @@ "json_schema": {}, "supported_sync_modes": ["full_refresh", "incremental"], "source_defined_cursor": false, - "default_cursor_field": null, + "default_cursor_field": ["last_seen"], "source_defined_primary_key": [["distinct_id"]] }, "sync_mode": "incremental", diff --git a/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py b/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py index a06c1f253853..b467c11504a6 100644 --- a/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py +++ b/airbyte-integrations/connectors/source-mixpanel/source_mixpanel/streams/engage.py @@ -67,7 +67,7 @@ class Engage(IncrementalMixpanelStream): primary_key: str = "distinct_id" page_size: int = 1000 # min 100 _total: Any = None - cursor_field = [] + cursor_field = "last_seen" @property def source_defined_cursor(self) -> bool: From f391ea0eae067b43bfdc7266e1e9dd63fd09d88c Mon Sep 17 00:00:00 2001 From: Octavia Squidington III Date: Fri, 7 Oct 2022 13:25:59 +0000 Subject: [PATCH 4/4] auto-bump connector version [ci skip] --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- airbyte-config/init/src/main/resources/seed/source_specs.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index 115fb24469c0..00bb41775b0e 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -646,7 +646,7 @@ - name: Mixpanel sourceDefinitionId: 12928b32-bf0a-4f1e-964f-07e12e37153a dockerRepository: airbyte/source-mixpanel - dockerImageTag: 0.1.27 + dockerImageTag: 0.1.28 documentationUrl: https://docs.airbyte.io/integrations/sources/mixpanel icon: mixpanel.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index 25a29d0d174e..3219b9c8c1d9 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -6560,7 +6560,7 @@ path_in_connector_config: - "credentials" - "client_secret" -- dockerImage: "airbyte/source-mixpanel:0.1.27" +- dockerImage: "airbyte/source-mixpanel:0.1.28" spec: documentationUrl: "https://docs.airbyte.io/integrations/sources/mixpanel" connectionSpecification: