From 68b16eba24746fb210328d54e4e77a67d5001988 Mon Sep 17 00:00:00 2001 From: Tino Merl Date: Fri, 4 Nov 2022 13:39:36 +0100 Subject: [PATCH 01/11] fixed issue with the org id not being an integer and deleted duplicate streams --- .../integration_tests/invalid_config.json | 2 +- .../integration_tests/sample_config.json | 2 +- .../source-linkedin-pages/source_linkedin_pages/source.py | 4 +--- .../source-linkedin-pages/source_linkedin_pages/spec.json | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json index fd62f7bf71a6..a0fa475e00a5 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json +++ b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/invalid_config.json @@ -1,5 +1,5 @@ { - "org_id": 12345678, + "org_id": "12345678", "credentials": { "auth_method": "access_token", "access_token": "wrong_token_sra6ibiw0ZWEdMnC0ZizeD1gLRQP6u1pkQl" diff --git a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json index c32e7dbe2010..7399ec4e7981 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json +++ b/airbyte-integrations/connectors/source-linkedin-pages/integration_tests/sample_config.json @@ -1,5 +1,5 @@ { - "org_id": 12345678, + "org_id": "12345678", "credentials": { "auth_method": "access_token", "access_token": "example_token_string123" diff --git a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py index 3ae046808158..54a184101813 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py +++ b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py @@ -148,7 +148,5 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]: OrganizationLookup(config), FollowerStatistics(config), ShareStatistics(config), - TotalFollowerCount(config), - ShareStatistics(config), - TotalFollowerCount(config), + TotalFollowerCount(config) ] diff --git a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json index ba4b533c5782..abd9d54b35d6 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json +++ b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/spec.json @@ -9,7 +9,7 @@ "properties": { "org_id": { "title": "Organization ID", - "type": "integer", + "type": "string", "airbyte_secret": true, "description": "Specify the Organization ID", "examples": ["123456789"] From 7dad80e36071b585a558302557e10d03ff0ca0cd Mon Sep 17 00:00:00 2001 From: Tino Merl Date: Fri, 4 Nov 2022 13:45:07 +0100 Subject: [PATCH 02/11] bumped version to 0.1.1 --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- .../connectors/source-linkedin-pages/Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index fb7e5b2bec36..7b26378d73b6 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -681,7 +681,7 @@ - name: LinkedIn Pages sourceDefinitionId: af54297c-e8f8-4d63-a00d-a94695acc9d3 dockerRepository: airbyte/source-linkedin-pages - dockerImageTag: 0.1.0 + dockerImageTag: 0.1.1 documentationUrl: https://docs.airbyte.com/integrations/sources/linkedin-pages icon: linkedin.svg sourceType: api diff --git a/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile b/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile index 926f0c238fb0..fb22a9ee737d 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile +++ b/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile @@ -34,5 +34,5 @@ COPY source_linkedin_pages ./source_linkedin_pages ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.0 +LABEL io.airbyte.version=0.1.1 LABEL io.airbyte.name=airbyte/source-linkedin-pages From 8d90b4dd4a6b8a577a8f3a1a6ed0fa7351972043 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sat, 5 Nov 2022 03:18:43 +0000 Subject: [PATCH 03/11] Update source_definitions.yaml --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index 40dc971f1168..0d47201322d7 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -681,7 +681,7 @@ - name: LinkedIn Pages sourceDefinitionId: af54297c-e8f8-4d63-a00d-a94695acc9d3 dockerRepository: airbyte/source-linkedin-pages - dockerImageTag: 0.1.1 + dockerImageTag: 0.1.0 documentationUrl: https://docs.airbyte.com/integrations/sources/linkedin-pages icon: linkedin.svg sourceType: api From bf1450b975af21079155f178d3885e436827e82a Mon Sep 17 00:00:00 2001 From: Vincent Koc <25068+koconder@users.noreply.github.com> Date: Sat, 5 Nov 2022 14:26:53 +1100 Subject: [PATCH 04/11] Update acceptance-test-config.yml --- .../connectors/source-linkedin-pages/acceptance-test-config.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml index 1ede1d61a6a2..8b4b5479d418 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml @@ -4,6 +4,8 @@ connector_image: airbyte/source-linkedin-pages:dev tests: spec: - spec_path: "source_linkedin_pages/spec.json" + backward_compatibility_tests_config: + disable_for_version: "0.1.0" connection: - config_path: "secrets/config.json" status: "succeed" From 4518d71fdb2e0f91bc7af216c758c8c08ad10d4c Mon Sep 17 00:00:00 2001 From: Vincent Koc <25068+koconder@users.noreply.github.com> Date: Sat, 5 Nov 2022 14:34:48 +1100 Subject: [PATCH 05/11] Update linkedin-pages.md --- docs/integrations/sources/linkedin-pages.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/integrations/sources/linkedin-pages.md b/docs/integrations/sources/linkedin-pages.md index 5801bcfff1f3..05a839cc4e7f 100644 --- a/docs/integrations/sources/linkedin-pages.md +++ b/docs/integrations/sources/linkedin-pages.md @@ -110,4 +110,5 @@ The source LinkedIn Pages can use either the `client_id`, `client_secret` and `r | Version | Date | Pull Request | Subject | | :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------- | +| 0.1.1 | 2022-11-05 | [18967](https://github.com/airbytehq/airbyte/pull/18967) | Fixed failing connection checks | | 0.1.0 | 2022-08-11 | [13098](https://github.com/airbytehq/airbyte/pull/13098) | Initial Release | \ No newline at end of file From 49d1ac5eb152b0af1a460939aae8cd09f36126d7 Mon Sep 17 00:00:00 2001 From: Vincent Koc <25068+koconder@users.noreply.github.com> Date: Sat, 5 Nov 2022 14:43:20 +1100 Subject: [PATCH 06/11] black formatting for python --- .../source-linkedin-pages/source_linkedin_pages/source.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py index 54a184101813..d4038467fc3b 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py +++ b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py @@ -144,9 +144,4 @@ def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) -> def streams(self, config: Mapping[str, Any]) -> List[Stream]: config["authenticator"] = self.get_authenticator(config) - return [ - OrganizationLookup(config), - FollowerStatistics(config), - ShareStatistics(config), - TotalFollowerCount(config) - ] + return [OrganizationLookup(config), FollowerStatistics(config), ShareStatistics(config), TotalFollowerCount(config)] From ddddf4baf5991f9c9faf0bcba605edad6869722a Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Mon, 13 Mar 2023 13:58:08 -0300 Subject: [PATCH 07/11] fix tests --- .../source-linkedin-pages/acceptance-test-config.yml | 2 ++ .../source_linkedin_pages/source.py | 9 ++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml index 8b4b5479d418..5e8968838257 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml @@ -13,6 +13,8 @@ tests: status: "failed" discovery: - config_path: "secrets/config.json" + backward_compatibility_tests_config: + disable_for_version: "0.1.0" basic_read: - config_path: "secrets/config.json" configured_catalog_path: "integration_tests/configured_catalog.json" diff --git a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py index d4038467fc3b..4c98017d677e 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py +++ b/airbyte-integrations/connectors/source-linkedin-pages/source_linkedin_pages/source.py @@ -144,4 +144,11 @@ def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) -> def streams(self, config: Mapping[str, Any]) -> List[Stream]: config["authenticator"] = self.get_authenticator(config) - return [OrganizationLookup(config), FollowerStatistics(config), ShareStatistics(config), TotalFollowerCount(config)] + return [ + OrganizationLookup(config), + FollowerStatistics(config), + ShareStatistics(config), + TotalFollowerCount(config), + ShareStatistics(config), + TotalFollowerCount(config), + ] \ No newline at end of file From 462f2f31acae11814048b9039bee1ad84ff9f4fc Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Mon, 13 Mar 2023 14:34:05 -0300 Subject: [PATCH 08/11] update acceptance test file --- .../acceptance-test-config.yml | 36 +++++++++++-------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml index 69eee81ebd7c..535ba5a47283 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml +++ b/airbyte-integrations/connectors/source-linkedin-pages/acceptance-test-config.yml @@ -1,23 +1,29 @@ # See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) # for more information about how to configure these tests connector_image: airbyte/source-linkedin-pages:dev -tests: +test_strictness_level: low +acceptance_tests: spec: - - spec_path: "source_linkedin_pages/spec.json" - backward_compatibility_tests_config: - disable_for_version: "0.1.0" + tests: + - spec_path: "source_linkedin_pages/spec.json" + backward_compatibility_tests_config: + disable_for_version: "0.1.0" connection: - - config_path: "secrets/config.json" - status: "succeed" - - config_path: "integration_tests/invalid_config.json" - status: "failed" + tests: + - config_path: "secrets/config.json" + status: "succeed" + - config_path: "integration_tests/invalid_config.json" + status: "failed" discovery: - - config_path: "secrets/config.json" - backward_compatibility_tests_config: - disable_for_version: "0.1.0" + tests: + - config_path: "secrets/config.json" + backward_compatibility_tests_config: + disable_for_version: "0.1.0" basic_read: - - config_path: "secrets/config.json" - configured_catalog_path: "integration_tests/configured_catalog.json" + tests: + - config_path: "secrets/config.json" + configured_catalog_path: "integration_tests/configured_catalog.json" full_refresh: - - config_path: "secrets/config.json" - configured_catalog_path: "integration_tests/configured_catalog.json" + tests: + - config_path: "secrets/config.json" + configured_catalog_path: "integration_tests/configured_catalog.json" From d5b5eaf63832e7ea86f563bde8694a3e58e17c8b Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Thu, 16 Mar 2023 13:24:55 -0300 Subject: [PATCH 09/11] change break spec - backward compt. --- .../connectors/source-linkedin-pages/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile b/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile index fb22a9ee737d..ff17f19c5d99 100644 --- a/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile +++ b/airbyte-integrations/connectors/source-linkedin-pages/Dockerfile @@ -34,5 +34,5 @@ COPY source_linkedin_pages ./source_linkedin_pages ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.1 +LABEL io.airbyte.version=1.0.0 LABEL io.airbyte.name=airbyte/source-linkedin-pages From fa3703678829ae4274996bc2f0df70ca08dd4904 Mon Sep 17 00:00:00 2001 From: marcosmarxm Date: Thu, 16 Mar 2023 15:27:28 -0300 Subject: [PATCH 10/11] fix changelog --- docs/integrations/sources/linkedin-pages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/integrations/sources/linkedin-pages.md b/docs/integrations/sources/linkedin-pages.md index 469ce2e9d0a4..ab06e16ba493 100644 --- a/docs/integrations/sources/linkedin-pages.md +++ b/docs/integrations/sources/linkedin-pages.md @@ -110,5 +110,5 @@ The source LinkedIn Pages can use either the `client_id`, `client_secret` and `r | Version | Date | Pull Request | Subject | | :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------- | -| 0.1.1 | 2022-11-05 | [18967](https://github.com/airbytehq/airbyte/pull/18967) | Fixed failing connection checks | +| 1.0.0 | 2023-03-16 | [18967](https://github.com/airbytehq/airbyte/pull/18967) | Fixed failing connection checks | | 0.1.0 | 2022-08-11 | [13098](https://github.com/airbytehq/airbyte/pull/13098) | Initial Release | From aedafc321b568378415ce73ab8a530ffc192a405 Mon Sep 17 00:00:00 2001 From: Octavia Squidington III Date: Thu, 16 Mar 2023 18:40:47 +0000 Subject: [PATCH 11/11] auto-bump connector version --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- airbyte-config/init/src/main/resources/seed/source_specs.yaml | 4 ++-- connectors.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index cc17ec2f38db..a41b9a586200 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -1077,7 +1077,7 @@ - name: LinkedIn Pages sourceDefinitionId: af54297c-e8f8-4d63-a00d-a94695acc9d3 dockerRepository: airbyte/source-linkedin-pages - dockerImageTag: 0.1.0 + dockerImageTag: 1.0.0 documentationUrl: https://docs.airbyte.com/integrations/sources/linkedin-pages icon: linkedin.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index 345ada7dcf4e..759ba9432a32 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -7894,7 +7894,7 @@ - - "client_secret" oauthFlowOutputParameters: - - "refresh_token" -- dockerImage: "airbyte/source-linkedin-pages:0.1.0" +- dockerImage: "airbyte/source-linkedin-pages:1.0.0" spec: documentationUrl: "https://docs.airbyte.com/integrations/sources/linkedin-pages/" connectionSpecification: @@ -7907,7 +7907,7 @@ properties: org_id: title: "Organization ID" - type: "integer" + type: "string" airbyte_secret: true description: "Specify the Organization ID" examples: diff --git a/connectors.md b/connectors.md index faa1b03e8f81..794b1c265b15 100644 --- a/connectors.md +++ b/connectors.md @@ -124,7 +124,7 @@ | **Lemlist** | x | Source | airbyte/source-lemlist:0.1.1 | alpha | [link](https://docs.airbyte.com/integrations/sources/lemlist) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lemlist) | `789f8e7a-2d28-11ec-8d3d-0242ac130003` | | **Lever Hiring** | Lever Hiring icon | Source | airbyte/source-lever-hiring:0.1.3 | alpha | [link](https://docs.airbyte.com/integrations/sources/lever-hiring) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lever-hiring) | `3981c999-bd7d-4afc-849b-e53dea90c948` | | **LinkedIn Ads** | LinkedIn Ads icon | Source | airbyte/source-linkedin-ads:0.1.15 | generally_available | [link](https://docs.airbyte.com/integrations/sources/linkedin-ads) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-ads) | `137ece28-5434-455c-8f34-69dc3782f451` | -| **LinkedIn Pages** | LinkedIn Pages icon | Source | airbyte/source-linkedin-pages:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/linkedin-pages) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-pages) | `af54297c-e8f8-4d63-a00d-a94695acc9d3` | +| **LinkedIn Pages** | LinkedIn Pages icon | Source | airbyte/source-linkedin-pages:1.0.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/linkedin-pages) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-pages) | `af54297c-e8f8-4d63-a00d-a94695acc9d3` | | **Linnworks** | Linnworks icon | Source | airbyte/source-linnworks:0.1.5 | alpha | [link](https://docs.airbyte.com/integrations/sources/linnworks) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linnworks) | `7b86879e-26c5-4ef6-a5ce-2be5c7b46d1e` | | **Lokalise** | Lokalise icon | Source | airbyte/source-lokalise:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/lokalise) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lokalise) | `45e0b135-615c-40ac-b38e-e65b0944197f` | | **Looker** | Looker icon | Source | airbyte/source-looker:0.2.8 | alpha | [link](https://docs.airbyte.com/integrations/sources/looker) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-looker) | `00405b19-9768-4e0c-b1ae-9fc2ee2b2a8c` |