test new AMI

[git-phu]

Use new github runner AMI that is fully documented here: https://github.com/airbytehq/airbyte-cloud/pull/3445

closes #16265

[git-phu]

should we include a link to internal docs in oss?

[evantahler]

I think that's fine

[evantahler]

Can you remove the AMI override here (

airbyte/.github/workflows/test-command.yml

Line 65 in 0dddc1e

ec2-image-id: ami-06cf12549e3d9c522

) and then we can test out a /test connector run as well?

[git-phu]

Can you remove the AMI override here (

airbyte/.github/workflows/test-command.yml

Line 65 in 0dddc1e

ec2-image-id: ami-06cf12549e3d9c522

) and then we can test out a /test connector run as well?

@evantahler done!

[evantahler]

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3526657107
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3526657107
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/graphql.py           145      1    99%
source_github/streams.py           796     44    94%
source_github/source.py            104     27    74%
----------------------------------------------------
TOTAL                             9868     72    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

All Passed

[evantahler]

Dang. Looks like the actions run off the yaml defined in master. In this PR we removed the override

https://github.com/airbytehq/airbyte/pull/19694/files#diff-2476bc10fa0b4bbb9f8634037b4828d5501795b3549ad2ebd82c071f4af13947L64-L65

But, the action still ran with the old AMI:

ec2-image-id: ami-06cf12549e3d9c522

[evantahler]

This PR probably closes #16265

[evantahler]

YOLO since we can't test it I guess 🤷

[git-phu]

gonna merge this now and watch for regressions