From 9de8dfb59dfe9cfb68bd8f68678eada3e1cdb4d4 Mon Sep 17 00:00:00 2001 From: Rodi Reich Zilberman <867491+rodireich@users.noreply.github.com> Date: Tue, 1 Aug 2023 18:04:33 -0700 Subject: [PATCH 1/3] Bump versions for mssql strict-encrypt --- .../connectors/source-mssql-strict-encrypt/Dockerfile | 2 +- .../connectors/source-mssql-strict-encrypt/metadata.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte-integrations/connectors/source-mssql-strict-encrypt/Dockerfile b/airbyte-integrations/connectors/source-mssql-strict-encrypt/Dockerfile index 3ed6d114efd5..de7b8cbb7dfc 100644 --- a/airbyte-integrations/connectors/source-mssql-strict-encrypt/Dockerfile +++ b/airbyte-integrations/connectors/source-mssql-strict-encrypt/Dockerfile @@ -24,5 +24,5 @@ ENV APPLICATION source-mssql-strict-encrypt COPY --from=build /airbyte /airbyte -LABEL io.airbyte.version=1.1.0 +LABEL io.airbyte.version=1.1.1 LABEL io.airbyte.name=airbyte/source-mssql-strict-encrypt diff --git a/airbyte-integrations/connectors/source-mssql-strict-encrypt/metadata.yaml b/airbyte-integrations/connectors/source-mssql-strict-encrypt/metadata.yaml index ae396634b811..0ef929896d48 100644 --- a/airbyte-integrations/connectors/source-mssql-strict-encrypt/metadata.yaml +++ b/airbyte-integrations/connectors/source-mssql-strict-encrypt/metadata.yaml @@ -11,7 +11,7 @@ data: connectorSubtype: database connectorType: source definitionId: b5ea17b1-f170-46dc-bc31-cc744ca984c1 - dockerImageTag: 1.1.0 + dockerImageTag: 1.1.1 dockerRepository: airbyte/source-mssql-strict-encrypt githubIssueLabel: source-mssql icon: mssql.svg From 668714e37c260d8210430d7bd419b06d76f0a8d5 Mon Sep 17 00:00:00 2001 From: Rodi Reich Zilberman <867491+rodireich@users.noreply.github.com> Date: Thu, 3 Aug 2023 11:31:59 -0700 Subject: [PATCH 2/3] Fix failing test --- .../airbyte/integrations/source/mssql/CdcMssqlSourceTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java b/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java index 4e220fc2425c..9c6eb3a36edd 100644 --- a/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java +++ b/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java @@ -314,7 +314,7 @@ void testAssertSnapshotIsolationDisabled() { // set snapshot_isolation level to "Read Committed" to disable snapshot .put("snapshot_isolation", "Read Committed") .build()); - Jsons.replaceNestedValue(config, List.of("replication"), replicationConfig); + Jsons.replaceNestedValue(config, List.of("replication_method"), replicationConfig); assertDoesNotThrow(() -> source.assertSnapshotIsolationAllowed(config, testJdbcDatabase)); switchSnapshotIsolation(false, dbName); assertDoesNotThrow(() -> source.assertSnapshotIsolationAllowed(config, testJdbcDatabase)); From 72e32866dbd19b3be2e0065877e03c79f569c4eb Mon Sep 17 00:00:00 2001 From: Rodi Reich Zilberman <867491+rodireich@users.noreply.github.com> Date: Thu, 3 Aug 2023 11:33:25 -0700 Subject: [PATCH 3/3] Fix failing test --- .../airbyte/integrations/source/mssql/CdcMssqlSourceTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java b/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java index 9c6eb3a36edd..a2af96300cb8 100644 --- a/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java +++ b/airbyte-integrations/connectors/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java @@ -181,7 +181,7 @@ public String createSchemaQuery(final String schemaName) { // TODO : Delete this Override when MSSQL supports individual table snapshot @Override - public void newTableSnapshotTest() throws Exception { + public void newTableSnapshotTest() { // Do nothing } @@ -350,7 +350,7 @@ void testCdcCheckOperations() throws Exception { void testCdcCheckOperationsWithDot() throws Exception { // assertCdcEnabledInDb and validate escape with special character switchCdcOnDatabase(true, dbNamewithDot); - AirbyteConnectionStatus status = getSource().check(getConfig()); + final AirbyteConnectionStatus status = getSource().check(getConfig()); assertEquals(status.getStatus(), AirbyteConnectionStatus.Status.SUCCEEDED); }