From 5c274a8de0ce7eb53a6ea0d21cda173a92e59d26 Mon Sep 17 00:00:00 2001 From: Xiaohan Song Date: Mon, 13 Nov 2023 16:50:44 -0800 Subject: [PATCH 1/3] be sure to load connector secrets for acceptance test --- .github/workflows/connector-performance-command.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/connector-performance-command.yml b/.github/workflows/connector-performance-command.yml index c86c798841f0..33e544f6f552 100644 --- a/.github/workflows/connector-performance-command.yml +++ b/.github/workflows/connector-performance-command.yml @@ -179,6 +179,8 @@ jobs: run: | export PATH="$PATH:/root/.local/bin" ci_credentials connectors-performance/$HARNESS_TYPE write-to-storage + connector_name=$(echo ${{ inputs.connector }} | cut -d / -f 2) + ci_credentials connectors-performance/$connector_name write-to-storage env: GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} HARNESS_TYPE: ${{ steps.which-harness.outputs.harness_type }} From 166ed2cb39413cc89a11e3df3deaff4bea91bc65 Mon Sep 17 00:00:00 2001 From: Xiaohan Song Date: Tue, 14 Nov 2023 09:54:30 -0800 Subject: [PATCH 2/3] update connector parsing logic --- .github/workflows/connector-performance-command.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/connector-performance-command.yml b/.github/workflows/connector-performance-command.yml index 33e544f6f552..bb199c077663 100644 --- a/.github/workflows/connector-performance-command.yml +++ b/.github/workflows/connector-performance-command.yml @@ -179,7 +179,7 @@ jobs: run: | export PATH="$PATH:/root/.local/bin" ci_credentials connectors-performance/$HARNESS_TYPE write-to-storage - connector_name=$(echo ${{ inputs.connector }} | cut -d / -f 2) + connector_name=$(echo ${{ inputs.connector }} | sed 's,.*/,,') ci_credentials connectors-performance/$connector_name write-to-storage env: GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} @@ -197,7 +197,7 @@ jobs: run: | echo "Building... ${{inputs.connector}}" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY # this is a blank line - connector_name=$(echo ${{ inputs.connector }} | cut -d / -f 2) + connector_name=$(echo ${{ inputs.connector }} | sed 's,.*/,,') echo "Running ./gradlew :airbyte-integrations:connectors:$connector_name:build -x check" ./gradlew :airbyte-integrations:connectors:$connector_name:build -x check env: From c9ee98c2f3f13fed14ebaaab8ea86125a76ee9cf Mon Sep 17 00:00:00 2001 From: Xiaohan Song Date: Tue, 14 Nov 2023 09:55:11 -0800 Subject: [PATCH 3/3] remove base prefix --- .github/workflows/connector-performance-command.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/connector-performance-command.yml b/.github/workflows/connector-performance-command.yml index bb199c077663..3ed30a4ceb77 100644 --- a/.github/workflows/connector-performance-command.yml +++ b/.github/workflows/connector-performance-command.yml @@ -137,7 +137,7 @@ jobs: id: regex uses: AsasInnab/regex-action@v1 with: - regex_pattern: "^((connectors|bases)/)?[a-zA-Z0-9-_]+$" + regex_pattern: "^(connectors/)?[a-zA-Z0-9-_]+$" regex_flags: "i" # required to be set for this plugin search_string: ${{ inputs.connector }} - name: Validate input workflow format