Destinations CDK: Set default namespace lower in the async framework call stack #38086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
from
7fa81d6 to
82331ab
Compare
|
@gisripa I got sketched out by some of our catalog/stream handling when I was moving the default namespace stuff into CatalogParser. This PR pushes that logic from AsyncStreamConsumer into BufferEnqueue, which I think means:
(I need to restack #38075 onto this pr now) |
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
from
82331ab to
ec47982
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
d361d45 to
3dfed9e
Compare
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
from
ec47982 to
0c254d5
Compare
edgao
commented
May 9, 2024
| @@ -244,20 +244,6 @@ abstract class AbstractJdbcDestination<DestinationState : MinimumDestinationStat | |||
| outputRecordCollector: Consumer<AirbyteMessage> | |||
| ): SerializedAirbyteMessageConsumer? { | |||
| val database = getDatabase(getDataSource(config)) | |||
| // Short circuit for non-v2 destinations. | |||
There was a problem hiding this comment.
pre-dv2 destinations no longer exist. Delete this.
(sort of... technically they exist, but we'll just bring them up to scratch when we next work on them)
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
4 times, most recently
from
03051ed to
d570a3d
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
3dfed9e to
a3bb96c
Compare
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
from
d570a3d to
eb2deb2
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
a3bb96c to
eca8010
Compare
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
from
eb2deb2 to
1571a5f
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
eca8010 to
7058132
Compare
edgao
force-pushed
the
edgao/better_default_namespace_tracking
branch
from
1571a5f to
3384ef0
Compare
This was referenced May 23, 2024
This was referenced May 28, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/2413 ?