Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Slack: add float_ts field #4683

Merged
merged 9 commits into from
Jul 14, 2021
Merged

🐛 Source Slack: add float_ts field #4683

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3c3d850
rename float_ts to ts cursor_field
marcosmarxm Jul 10, 2021
a8156f4
add float_ts
marcosmarxm Jul 10, 2021
bd02204
change float_ts to number
marcosmarxm Jul 10, 2021
a29df10
change channel_msg
marcosmarxm Jul 10, 2021
0e3c3f7
bump version
marcosmarxm Jul 10, 2021
bedfe3b
increase default timeout_seconds slack acc test
marcosmarxm Jul 14, 2021
6271818
timeout_seconds to 1750
marcosmarxm Jul 14, 2021
25e3083
timeout_seconds to 3600 :p
marcosmarxm Jul 14, 2021
ab2173c
add changelog for slack connector
marcosmarxm Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/c2281cee-86f9-4a86-bb48-d23286b4c7bd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "c2281cee-86f9-4a86-bb48-d23286b4c7bd",
"name": "Slack",
"dockerRepository": "airbyte/source-slack",
"dockerImageTag": "0.1.7",
"dockerImageTag": "0.1.8",
"documentationUrl": "https://hub.docker.com/repository/docker/airbyte/source-slack",
"icon": "slack.svg"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@
- sourceDefinitionId: c2281cee-86f9-4a86-bb48-d23286b4c7bd
name: Slack
dockerRepository: airbyte/source-slack
dockerImageTag: 0.1.7
dockerImageTag: 0.1.8
documentationUrl: https://hub.docker.com/repository/docker/airbyte/source-slack
icon: slack.svg
- sourceDefinitionId: 6ff047c0-f5d5-4ce5-8c81-204a830fa7e1
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-slack/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.7
LABEL io.airbyte.version=0.1.8
LABEL io.airbyte.name=airbyte/source-slack
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-slack/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ tests:
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
timeout_seconds: 3600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking the logs the timeout could be something around 1500~1750 :p

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marcos, i'd just keep it at 3600. It's not worth getting this number exactly right if we know this connector takes a long time

cursor_paths:
channel_messages: ["float_ts"]
full_refresh:
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-slack/integration_tests/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@
"ts": {
"type": ["null", "string"]
},
"float_ts": {
"type": ["null", "number"]
},
"type": {
"type": ["null", "string"]
},
Expand Down
7 changes: 5 additions & 2 deletions airbyte-integrations/connectors/source-slack/sample_files/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"type": ["null", "string"]
},
"ts": {
"type": ["null", "string"]
},
"float_ts": {
"type": ["null", "number"]
},
"team": {
Expand Down Expand Up @@ -66,9 +69,9 @@
},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["ts"]
"default_cursor_field": ["float_ts"]
},
"cursor_field": ["ts"],
"cursor_field": ["float_ts"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
}
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-slack/source_slack/schemas/channel_messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@
"ts": {
"type": ["null", "string"]
},
"float_ts": {
"type": ["null", "number"]
},
"type": {
"type": ["null", "string"]
},
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-slack/source_slack/schemas/threads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
"type": ["null", "string"]
},
"ts": {
"type": ["null", "string"]
},
"float_ts": {
"type": ["null", "number"]
},
"team": {
Expand Down