-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth config to oauth api #7798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach a lot. It's very well-scoped to the inputs required for oauth. I'd go for this one over #7678
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some questions:
- How will it handle
airbyte_secret
fields? - I believe we don't yet have file upload, but what if we have it at some point, won't it break this endpoint? Though if we upload file initially and then just send ids - it should be fine. But we need to consider such a case in advance.
I understand that this prop is just additional and we are free to send everything we want here, but the problem is that we can't send exact connectorConfiguration
property as it may be not valid yet, so there is a possibility that we will send some temp frontend state.
In this PR, we changed our minds and instead of sending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the short PR with just the iface change!
* Change protocol for new OAuthConfigSpecification * Add examples * Add protocol object to api too Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
airbyte-protocol/models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
Outdated
Show resolved
Hide resolved
* Change OAuth API * Change protocol for new OAuth Spec (airbytehq#7827) * Add examples * Add protocol object to api too Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
What
New OAuth flows will need values from the connector config in #6971
How
Alteernative to #7678
This API changes adds an "optional" auth config parameter to the API endpoint to be potentially used during oauth flows (depends on flow implementation)
Context