Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Salesforce: Add Transform for output records #7885

Merged

Conversation

yevhenii-ldv
Copy link
Contributor

@yevhenii-ldv yevhenii-ldv commented Nov 11, 2021

What

In this pull request, Transform for Salesforce connector has been added in order to prevent cases when we can receive incorrect data for records of the data type anyType and calculated..

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 11, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Nov 11, 2021

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1450833097
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1450833097
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-salesforce/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 Name                                 Stmts   Miss  Cover
	   self._warn("No data was collected.", slug="no-data-collected")
	 --------------------------------------------------------
	 source_salesforce/__init__.py            2      2     0%
	 source_salesforce/api.py               114    114     0%
	 source_salesforce/exceptions.py          1      1     0%
	 source_salesforce/rate_limiting.py      22     22     0%
	 source_salesforce/source.py             52     52     0%
	 source_salesforce/streams.py           182    182     0%
	 --------------------------------------------------------
	 TOTAL                                  373    373     0%

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 11, 2021 22:41 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 11, 2021 22:42 Inactive
Copy link
Contributor

@sergei-solonitcyn sergei-solonitcyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 2 checks failed.
If it has been already fixed in master, let's do rebase (or merge from master) and recreate the PR.

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 12, 2021 14:16 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 12, 2021 14:17 Inactive
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 12, 2021 16:48 Inactive
@VasylLazebnyk VasylLazebnyk added this to the Connectors 2021-11-12 milestone Nov 15, 2021
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Nov 15, 2021

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1462354388
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1462354388

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 15, 2021 13:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 15, 2021 13:27 Inactive
@yevhenii-ldv yevhenii-ldv merged commit d9135b0 into master Nov 15, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/salesforce-add-transform-for-output-records branch November 15, 2021 13:41
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 15, 2021 13:42 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Source Salesforce: Add Transform for output records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants