Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 一時停止機能 #837

Merged
merged 7 commits into from
Nov 10, 2024
Merged

feat: 一時停止機能 #837

merged 7 commits into from
Nov 10, 2024

Conversation

FineArchs
Copy link
Member

What

interpreter.pause()で実行の一時停止ができるようにします。
interpreter.unpause()で再開します。
Playgroundへのボタンの追加も行っています。

Additional info (optional)

再開後にAsync:系の待ち時間がリセットされる不具合がありますが、修正の目処は立っていません

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.68354% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/interpreter/lib/std.ts 41.17% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/interpreter/index.ts 94.82% <100.00%> (+9.02%) ⬆️
src/interpreter/value.ts 100.00% <ø> (ø)
src/interpreter/lib/std.ts 76.82% <41.17%> (-2.41%) ⬇️

... and 27 files with indirect coverage changes

@takejohn
Copy link
Contributor

用語としてpause/unpauseよりsuspend/resumeが自然な気がするんですけどどうでしょう?

@FineArchs
Copy link
Member Author

個人的には「リソース節約状態になる一時停止」がsuspend、「いつでも再開できる一時停止」がpauseというイメージがあります。
あと、pauseとunpauseはパッと見ただけで対応関係にあることが分かるという嬉しさがあると思います。

test/interpreter.ts Outdated Show resolved Hide resolved
FineArchs and others added 2 commits November 6, 2024 01:01
Co-authored-by: Take-John <105504345+takejohn@users.noreply.github.com>
src/interpreter/index.ts Outdated Show resolved Hide resolved
Co-authored-by: salano_ym <53254905+salano-ym@users.noreply.github.com>
Co-authored-by: uzmoi <rizzzse@gmail.com>
@FineArchs FineArchs merged commit 95f5f1f into aiscript-dev:master Nov 10, 2024
4 checks passed
@FineArchs FineArchs deleted the pause branch November 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants