Javascript Hooks #70
Merged
Javascript Hooks #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrieveslaach
commented
Jul 5, 2021
| @@ -104,7 +104,6 @@ The list of available handlebars variables: | |||
|
|
|||
| - `application`: The companion's application information | |||
| - `name`: The application name | |||
| - `applicationPath`: The root path to the application. | |||
There was a problem hiding this comment.
This variable never existed. So, I decide to remove it from the documentation.
schrieveslaach
commented
Jul 5, 2021
| @@ -2,7 +2,7 @@ | |||
| * ========================LICENSE_START================================= | |||
There was a problem hiding this comment.
Due to a hint of cargo clippy the file api/src/apps/apps.rs has been renamed to api/src/apps/mod.rs. Unfortunately, git does not recognize the diff.
|
The changes seem to be fine. Some changes I do not get because I do not know rust that well but they look like they are not that important, so I believe they work. I think the hooks could be made a little clearer in the README. |
binepedia
approved these changes
Jul 6, 2021
binepedia
reviewed
Jul 12, 2021
This commit introduces the concept of hook to PREvant that can be used to manipulate the deployment before handing it over to the actual infrastructure layer. With hooks in place you are able to add custom logik, such as reconfiguring services to use a different database configuration. See README.md files for example usage. Further, the commit fixes some clippy hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of hook to PREvant that can be used to manipulate the deployment before handing it over to the actual infrastructure layer. With hooks in place you are able to add custom logik, such as re-configuring services to use a different database configuration.
Fixes #41