0.6.0 changes #76
Merged
0.6.0 changes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composite builds that include multiple builds that use reckon can run into unexpected behavior, because any reckon.* props passed in on the command line are used by all builds. This can cause it to try to increment a version incorrectly. The new behavior makes it so that only the main build within a composite will actually respect the gradle properties. This does imply that you can't really release a version of an included build, but the expectation is that that's not what anyone would intend to do. That could be proven wrong, but it would require something more involved to support. This fixes #74.
The reckon.snapshot property is a little confusing to set the value of, since true means snapshot and final is false. It seems a little backwards. The reckon.stage approach is a little more natural, explicitly passing in 'snapshot' or 'final'. This will deprecate use of reckon.snapshot, to be removed in 1.0.0. This fixes #71.
This fixes #65.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.