diff --git a/CONTRIBUTORS.rst b/CONTRIBUTORS.rst index 823bed247..ddf18a90b 100644 --- a/CONTRIBUTORS.rst +++ b/CONTRIBUTORS.rst @@ -53,12 +53,14 @@ - Leo Torres (@leotrs) - Magnus N. Malmquist (@magnunm) - Mark Davidoff (@markddavidoff) +- Martin HΓ€cker (@dwt) - martinRenou (@martinRenou) - Mat Clayton (@matclayton) - Matthias Bussonnier (@Carreau) - Matthijs van der Burgh (@MatthijsBurgh) - mayk0gan (@mayk0gan) - Min RK (@minrk) +- My-Tien Nguyen (@my-tien) - Mystic-Mirage (@Mystic-Mirage) - Nathan Huffman (@njhuffman) - Nutchanon Ninyawee (@wasdee) @@ -84,6 +86,7 @@ - Thomas GΓΌttler (@guettli) - TJ Kolleh (@tkolleh) - Tobias Diez (@tobiasdiez) +- Trent Apted (@tapted) - Trevor Gross (@tgross35) - Victor Cui (@victorcui96) - Vivek Kushwaha (@yoursvivek) diff --git a/README.rst b/README.rst index f235ce81d..d6b718292 100644 --- a/README.rst +++ b/README.rst @@ -1469,6 +1469,19 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› + + + @dwt +
+ + Martin HΓ€cker + + +
+ πŸ› + + + @matclayton @@ -1480,8 +1493,6 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› - - @Carreau @@ -1517,6 +1528,17 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ’» + + + @my-tien +
+ + My-Tien Nguyen + + +
+ πŸ› + @Mystic-Mirage @@ -1530,6 +1552,8 @@ Thanks goes to these wonderful people (`emoji key`_): πŸ“– πŸ‘€ + + @njhuffman @@ -1553,8 +1577,6 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› - - @Pacu2 @@ -1602,6 +1624,8 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› + + @flying-sheep @@ -1624,8 +1648,6 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› - - @ioggstream @@ -1670,6 +1692,8 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ‘€ + + @hauntsaninja @@ -1692,8 +1716,6 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ‘€ - - @soxofaan @@ -1738,6 +1760,8 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ’» + + @guettli @@ -1759,8 +1783,17 @@ Thanks goes to these wonderful people (`emoji key`_):
- - + + + @tapted +
+ + Trent Apted + + +
+ πŸ› + @tgross35 @@ -1795,6 +1828,8 @@ Thanks goes to these wonderful people (`emoji key`_): πŸ› πŸ“– + + @Hainguyen1210 @@ -1829,8 +1864,6 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› - - @zachnorton4C @@ -1864,6 +1897,8 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› + + @leej3 @@ -1898,8 +1933,6 @@ Thanks goes to these wonderful people (`emoji key`_): πŸ’» πŸ‘€ - - @mayk0gan @@ -1933,6 +1966,8 @@ Thanks goes to these wonderful people (`emoji key`_):
πŸ› + + @samoylovfp diff --git a/contributors.yaml b/contributors.yaml index a8a9a9e64..310149376 100644 --- a/contributors.yaml +++ b/contributors.yaml @@ -65,6 +65,8 @@ dhrvjha: - {link_type: pulls-author, type: Code} dsmanl: - {link_type: issues, type: Bug reports} +dwt: + - {link_type: issues, type: Bug reports} falkben: - {link_type: pulls-author, type: Documentation} fizbin: @@ -127,6 +129,8 @@ minrk: - {link_type: darker-feedstock-issues, type: Code} muggenhor: - {link_type: commits, type: Code} +my-tien: + - {link_type: issues, type: Bug reports} njhuffman: - {link_type: issues, type: Bug reports} - {link_type: commits, type: Code} @@ -164,6 +168,8 @@ strzonnek: - {link_type: issues, type: Bug reports} talhajunaidd: - {link_type: commits, type: Code} +tapted: + - {link_type: issues, type: Bug reports} tgross35: - {link_type: issues, type: Bug reports} tkolleh: diff --git a/release_tools/update_contributors.py b/release_tools/update_contributors.py index 2ae466ebf..c5812b72b 100644 --- a/release_tools/update_contributors.py +++ b/release_tools/update_contributors.py @@ -316,6 +316,23 @@ def display_name(self) -> str: return self.name or self.login +RTL_OVERRIDE = "\u202e" + + +def _normalize_rtl_override(text: str) -> str: + """Normalize text surrounded by right-to-left override characters + + :param text: Text to normalize + :return: Normalized text + + """ + if not text: + return text + if text[0] != RTL_OVERRIDE or text[-1] != RTL_OVERRIDE: + return text + return text[-2:0:-1] + + def join_github_users_with_contributions( users_and_contributions: Dict[str, List[Contribution]], session: GitHubSession, @@ -330,9 +347,10 @@ def join_github_users_with_contributions( users: List[Contributor] = [] for username, contributions in users_and_contributions.items(): gh_user = cast(GitHubUser, session.get(f"/users/{username}").json()) + name = _normalize_rtl_override(gh_user["name"]) try: contributor = Contributor( - gh_user["id"], gh_user["name"], gh_user["login"], contributions + gh_user["id"], name, gh_user["login"], contributions ) except KeyError: click.echo(gh_user, err=True)