This repository has been archived by the owner on Aug 23, 2021. It is now read-only.
Fixing issues on rounded corners + borders #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viteinfinite
changed the title
pjechris
reviewed
Jan 26, 2017
| @@ -27,19 +46,19 @@ class BorderLayer : CALayer { | |||
| case .top: | |||
| self.draw(border: border, | |||
| path: path, | |||
| points: [ CGPoint(x: 0, y: 0), CGPoint(x: ctx.width, y: 0), CGPoint(x: ctx.width, y: Int(border.width)), CGPoint(x: 0, y: Int(border.width)) ]) | |||
| points: [ CGPoint(x: 0, y: 0), CGPoint(x: bounds.width, y: 0), CGPoint(x: bounds.width, y: border.width), CGPoint(x: 0, y: border.width) ]) | |||
There was a problem hiding this comment.
I guess this is correct but IMO ctx.width feels more correct as we can't be 100% sure that ctx == bounds
There was a problem hiding this comment.
Thing is that ctx depends on screen scale. So, if layer.contentsScale is 2.0 (for instance), ctx.width would be twice the bound width.
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow borders to be correctly drawn on views having rounded corners.
Also, fixing a major visual issue on antialiasing which prevented borders from having smooth corners.