fix: starting Sharding with separate Coordinator role, #31637 #31889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this feature was completely broken
* note that the ddata replicator is used for both
DDataShardCoordinator and DDataRememberEntities
- the DDataShardCoordinator replicator can be on the same role as the coordinator
- for remmeber entities it's both the CoordinatorStore and the ShardStore, to not complicate
that too much I used a replicator without role for remember entities when those two roles
are different
johanandren
approved these changes
Mar 17, 2023
akka-cluster-sharding/src/main/scala/akka/cluster/sharding/ShardRegion.scala
Show resolved
Hide resolved
| // when using another coordinator role than the shard role the coordinator may have to be started | ||
| val startCoordinatorMsg = StartCoordinatorIfNeeded(typeName, settings, allocationStrategy) | ||
| guardian ! startCoordinatorMsg | ||
| } |
There was a problem hiding this comment.
Ok, so if the node hosts shards, it will start the coordinator from the Start command, but if not we need this extra trigger.
There was a problem hiding this comment.
That is right, if it's not a "shard role" it will start a proxy, but that may also be a "coordinator role". The StartProxy message doesn't contain all needed parameters and that is also used in from elsewhere. Therefore I added this as a separate message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDataShardCoordinator and DDataRememberEntities
that too much I used a replicator without role for remember entities when those two roles
are different
Original contribution in #31487
References #31637