Ftp Connector: Adding last modified date and file size to FtpFile

[lowchinwei]

It is useful to return extra file metadata such as last modified date and file size in the ls api.

[juanjovazquez]

@lowchinwei Definitely, FTPFile object needs to be enriched. I need to take some time out for tackling this ;).

[svezfaz]

@juanjovazquez (1) modified date, (2) file size and (3) file permissions seem like the lowest-hanging fruits here.. The resulting model object would look something like

final case class FtpFile(
    name: String,
    path: String,
    isDirectory: Boolean,
    size: Long,
    lastModified: java.time.LocalDateTime,
    permissions: Set[java.nio.file.attribute.PosixFilePermission]
) {...}

Info about user and group is not that low-hanging, as FTP will give us nice names, where SFTP will give us numerical ids only.

Would a first PR to add the 3 above be welcome? Any feedback on the model object?

[eharik]

Could you add a couple parameters to FtpFile so it's FtpFile[UID, GID] or is that over complicating things? Either way, the richer FtpFile changes will be welcome! On Feb 16, 2017 4:00 PM, "Stefano Bonetti" <notifications@github.com> wrote: @juanjovazquez <https://github.com/juanjovazquez> (1) modified date, (2) file size and (3) file permissions seem like the lowest-hanging fruits here.. The resulting model object would look something like final case class FtpFile( name: String, path: String, isDirectory: Boolean, size: Long, lastModified: java.time.LocalDateTime, permissions: Set[java.nio.file.attribute.PosixFilePermission] ) {...} Info about user and group is not that low-hanging, as FTP will give us nice names, where SFTP will give us numerical ids only. Would a first PR to add the 3 above be welcome? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#153 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABP2w7l6KdGYOIFTOAy2__0X9eMIKnfwks5rdLjqgaJpZM4Ln6wn> .

[juanjovazquez]

@svezfaz the PR would be definitely welcome. Just a couple of things. java.time.LocalDateTime would force us to use Java 8, right?. I think this is still a strong requirement. What about the humble java.util.Date? (I know this API is not reliable but it could be a sensible decision). I'd rather go with joda time but I'm not sure if it's worth it in this case 'cause maybe the end user is not comfortable with the idea of including this additional dependency. OTOH, the isDirectory attribute is not helping much now as the Source is only generating proper file elements, i.e. isDirectory will always be false. I think we should change this in the context of other issue and the Source should generate both files and directories and let the user decide how to deal with that. Opinions?.

BTW, @eharik do you have a use case that justifies the uid and gid attributes?.

[svezfaz]

@juanjovazquez @eharik

• point taken on LocalDateTime. I am not super-keen on util.Date but the only alternative seems to be just a Long epoch timestamp. Too low level?
• for the isDirectory matter, indeed it makes sense to solve this as a separate issue. so we might leave this in for now?
• for the UID/GID, maybe we can skip this for now until we find a valid use case.

[juanjovazquez]

I'd have a look at GenericFile on the Camel project. Take into account that many Alpakka users will come from Camel (I'm one of them ;-)). I can see that lastModified is defined as long there, so I'd stick to this criteria.

Agreed with the rest of considerations.

[eharik]

Nope, no compelling use case right now. Just throwing out the suggestion.

…

On Feb 17, 2017 2:09 AM, "Stefano Bonetti" ***@***.***> wrote: @juanjovazquez <https://github.com/juanjovazquez> @eharik <https://github.com/eharik> - point taken on LocalDateTime. I am not super-keen on util.Date but the only alternative seems to be just a Long epoch timestamp. Too low level? - for the isDirectory matter, indeed it makes sense to solve this as a separate issue. so we might leave this in for now? - for the UID/GID, maybe we can skip this for now until we find a valid use case. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#153 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABP2wxs9cvj_W80I5yQScs4IOXSeLKktks5rdWO0gaJpZM4Ln6wn> .

[patriknw]

JDK8 is required anyway, by Akka

[ktoso]

Solved in #195