AWS SNS and SQS: Apache HTTP client is not used #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
dependency-change
2m
reviewed
Jun 19, 2019
project/Dependencies.scala
Outdated
| name = "netty-nio-client" | ||
| ), ExclusionRule(organization = "io.netty")), // ApacheV2 | ||
| "com.github.matsluni" %% "aws-spi-akka-http" % AwsSpiAkkaHttpVersion excludeAll // ApacheV2 | ||
| ExclusionRule(organization = "com.typesafe.akka"), |
There was a problem hiding this comment.
A bit weird formatting here. Maybe use () for a single ExclusionRule here as well as it is done below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As Alpakka SNS and SQS use Akka HTTP via aws-spi-akka-http, the Apache HTTP client can be excluded from the dependencies brought in by the AWS SDK 2.
References
#1695
matsluni/aws-spi-akka-http#11
Changes