Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch: use proper FlowWithContext #1766

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Elasticsearch: use proper FlowWithContext #1766

merged 2 commits into from
Jun 20, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Jun 20, 2019

Purpose

Replace the raw tuple-based "with context" implementation with the new types from Akka 2.5.23.

References

See #1713

@ennru ennru added this to the 1.0.3 milestone Jun 20, 2019
2m
2m approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice!

@2m 2m merged commit c137fcf into akka:master Jun 20, 2019
@ennru ennru deleted the elasticsearch-with-context branch June 20, 2019 13:19
@ennru ennru mentioned this pull request Jun 25, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
p:elasticsearch
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @2m