Failure to attain QoS is not bad #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a failure to attain a QoS level i.e. subscribe, was considered bad. The spec treats this condition as one being something for the application to handle e.g. a client can decide to proceed or not given that one of the topics being subscribed was able to be so. The fix is to deprecate the BadSubAckMessage and always return SubAck. This then permits the Subscriber to process SubAcks whether they are good or bad from the application's perspective.
|
CI is failing - although I suspect the test is flaky given the multitude number of times CI has been passing. Any advice? |
|
I built this locally and tested it. I can confirm that a Decoded SubAck: |
|
Great. Thanks for confirming. This PR is ready for review. |
|
ping @2m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, a failure to attain a QoS level when subscribing to a topic was considered bad. The spec treats this condition as one being something for the application to handle e.g. a client can decide to proceed or not given that one of the topics being subscribed fails or not.
The fix is to deprecate the
BadSubAckMessageand always returnSubAck. This then permits theSubscriberto processSubAcks whether they are good or bad from the application's perspective.Fixes ##1833 (comment)