Treat ConsumeFailed as a problem #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we get a ConsumeFailed exception in the Consumer, this is a problem. The problem should cause the client to shutdown in the same way that subscription, or unsubscription should fail. Same for the server. This fix addresses a long-standing issue we've had on a super slow machine where ConsumeFailed occurs from time to time, and the stream effectively hangs because the calling wasn't made aware of the problem and couldn't restart the connection etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get a
ConsumeFailedexception in theConsumerthen this is a problem that we cannot recover from. To recap,ConsumeFailedis when we've received aPublishfrom a remote and we need to acknowledge it, but our calling code hasn't yet done so. The problem should cause the client to shutdown in the same way that subscription, or unsubscription does when they fail. Same for the server.This fix should address a long-standing issue we've had on a super slow machine where
ConsumeFailedoccurs from time to time, and the stream effectively hangs because the caller wasn't made aware of the problem and couldn't restart the connection. Local testing confirms the fix should work.The fix also replaces the use of
watchWithwith justwatchas the former provides no means of discerning exceptions (reported akka/akka#26296).