Elasticsearch: store JSON strings #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
force-pushed
the
elasticsearch-write-strings
branch
from
bb58b6e
to
e3a3811
Compare
2m
approved these changes
Aug 7, 2019
| } | ||
|
|
||
| object StringMessageWriter extends StringMessageWriter { | ||
| val INSTANCE: StringMessageWriter = StringMessageWriter |
There was a problem hiding this comment.
Should this be called getInstance to be Java API friendly?
| "_doc", | ||
| ElasticsearchWriteSettings.create().withBufferSize(5), | ||
| client, | ||
| new StringMessageWriter())) |
There was a problem hiding this comment.
StringMessageWriter.getInstance() to reuse the same instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Document (Scala) and enable (Java) how to use properly formatted JSON documents without Spray or Jackson.
References
Implements #1825
Changes
StringMessageWriterMessageWriterin the Java APIBackground Context
#1825 asked for this support, which was available with the Scala DSL, but not the Java DSL.