Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XML] XML parsing exceptions (e.g. WFCException) should cleanly fail the XmlParsing stage rather than go unhandled #2532

Closed
jphelp32 opened this issue Nov 20, 2020 · 2 comments · Fixed by #3003
Labels

Comments

@jphelp32
Copy link
Contributor

In the XmlParsing stage, if any parsing error occurs, the exception from the underlying aalto parser goes unhandled and fails the stage. As a result, the exception is always logged at the ERROR log level by akka's logger. I think the better approach would be to catch all parsing exceptions and fail the stage cleanly via failStage(ex), so that the exception is not automatically logged, and consumers of the XmlParsing stage can determine how to react wrt to logging.

@ennru ennru added the p:xml label Nov 22, 2020
@ennru
Copy link
Member

ennru commented Nov 22, 2020

Thank you for this suggestion, sounds reasonable.
Please feel free to suggest these changes in a Pull Request.

@ennru
Copy link
Member

ennru commented Aug 27, 2023

Fixed with #3003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants