FTP - attribute enrichment of FTPFile #153 #195
Conversation
| val total = result.foldLeft(0L) { | ||
| case (acc, next) => acc + next.count | ||
| } | ||
| val total = result.map(_.count).sum |
There was a problem hiding this comment.
this traverses result twice, right?
There was a problem hiding this comment.
Given this is a test, I appreciate increased readability over performance. I am not too adamant about it, though :) I can put it back if there is a strong argument
There was a problem hiding this comment.
No strong argument at all. I guess it's just a matter of style.
There was a problem hiding this comment.
in a test readability definitely wins over pers in things like these IMHO, thanks!
| @@ -4,11 +4,13 @@ | |||
| package akka.stream.alpakka.ftp | |||
| package impl | |||
|
|
|||
| import org.apache.commons.net.ftp.{FTP, FTPClient} | |||
| import org.apache.commons.net.ftp.{FTP, FTPClient, FTPFile} | |||
|
|
|||
| import java.io.InputStream | ||
| import java.nio.file.Paths | ||
| import java.nio.file.attribute.PosixFilePermissions | ||
|
|
| import akka.stream.alpakka.ftp.RemoteFileSettings.SftpSettings | ||
| import com.jcraft.jsch.{ChannelSftp, JSch} | ||
|
|
| import scala.collection.immutable | ||
| import scala.util.Try | ||
| import java.io.InputStream | ||
| import java.nio.file.Paths | ||
|
|
| @@ -7,10 +7,12 @@ | |||
| import akka.stream.ActorMaterializer; | |||
| import akka.stream.Materializer; | |||
| import org.apache.mina.util.AvailablePortFinder; | |||
|
|
|||
| @@ -8,7 +8,8 @@ import akka.stream.IOResult | |||
| import akka.stream.scaladsl.Source | |||
| import akka.util.ByteString | |||
| import org.scalatest.concurrent.ScalaFutures | |||
| import org.scalatest.{BeforeAndAfter, BeforeAndAfterAll, Matchers, WordSpecLike} | |||
| import org.scalatest._ | |||
|
|
|||
There was a problem hiding this comment.
I'd rather not go with global imports: org.scalatest._
| @@ -3,10 +3,14 @@ | |||
| */ | |||
| package akka.stream.alpakka.ftp | |||
|
|
|||
| import java.nio.file.attribute.PosixFilePermission | |||
There was a problem hiding this comment.
So far, I've been putting the java imports at the end of the import list. Just by convention.
| import akka.stream.IOResult | ||
| import akka.stream.scaladsl.{Keep, Sink} | ||
| import akka.stream.testkit.scaladsl.TestSink | ||
| import org.scalatest.time.{Millis, Seconds, Span} | ||
|
|
| import akka.stream.IOResult | ||
| import akka.stream.scaladsl.{Keep, Sink} | ||
| import akka.stream.testkit.scaladsl.TestSink | ||
| import org.scalatest.time.{Millis, Seconds, Span} | ||
|
|
||
| import scala.concurrent.duration._ |
There was a problem hiding this comment.
I'd get rid of the global import on scala.concurrent.duration._
There was a problem hiding this comment.
this is to have the .millis and .minute conversions from duration package object. would you prefer not to use them?
svezfaz
force-pushed
the
153-FTP-ls-file-attributes
branch
from
eea5e2b
to
0a02acd
Compare
|
@juanjovazquez Thanks for reviewing! I updated the imports. |
svezfaz
force-pushed
the
153-FTP-ls-file-attributes
branch
from
0a02acd
to
f113aea
Compare
|
LGTM, resolved conflicts |
Handles #153