diff --git a/src/core/Akka.Remote/Configuration/Remote.conf b/src/core/Akka.Remote/Configuration/Remote.conf index 08c1fc87bc0..e5d0c7622b7 100644 --- a/src/core/Akka.Remote/Configuration/Remote.conf +++ b/src/core/Akka.Remote/Configuration/Remote.conf @@ -432,11 +432,6 @@ akka { # i.e. how long a connect may take until it is timed out connection-timeout = 15 s - # Toggles buffer pooling on and off inside DotNetty. - # Only intended to be a work-around for users who are still running on DotNetty v0.4.6-v0.4.7 - # for the following bug: https://github.com/akkadotnet/akka.net/issues/3370 - enable-pooling = true - # If set to "" then the specified dispatcher # will be used to accept inbound connections, and perform IO. If "" then # dedicated threads will be used. diff --git a/src/core/Akka.Remote/Transport/DotNetty/DotNettyTransport.cs b/src/core/Akka.Remote/Transport/DotNetty/DotNettyTransport.cs index 129a5e675ad..eb2e6b7fef2 100644 --- a/src/core/Akka.Remote/Transport/DotNetty/DotNettyTransport.cs +++ b/src/core/Akka.Remote/Transport/DotNetty/DotNettyTransport.cs @@ -275,7 +275,7 @@ protected Bootstrap ClientFactory(Address remoteAddress) .Option(ChannelOption.TcpNodelay, Settings.TcpNoDelay) .Option(ChannelOption.ConnectTimeout, Settings.ConnectTimeout) .Option(ChannelOption.AutoRead, false) - .Option(ChannelOption.Allocator, Settings.EnableBufferPooling ? (IByteBufferAllocator)PooledByteBufferAllocator.Default : UnpooledByteBufferAllocator.Default) + .Option(ChannelOption.Allocator, UnpooledByteBufferAllocator.Default) .ChannelFactory(() => Settings.EnforceIpFamily ? new TcpSocketChannel(addressFamily) : new TcpSocketChannel()) @@ -384,7 +384,7 @@ private ServerBootstrap ServerFactory() .Option(ChannelOption.TcpNodelay, Settings.TcpNoDelay) .Option(ChannelOption.AutoRead, false) .Option(ChannelOption.SoBacklog, Settings.Backlog) - .Option(ChannelOption.Allocator, Settings.EnableBufferPooling ? (IByteBufferAllocator)PooledByteBufferAllocator.Default : UnpooledByteBufferAllocator.Default) + .Option(ChannelOption.Allocator, UnpooledByteBufferAllocator.Default) .ChannelFactory(() => Settings.EnforceIpFamily ? new TcpServerSocketChannel(addressFamily) : new TcpServerSocketChannel()) diff --git a/src/core/Akka.Remote/Transport/DotNetty/TcpTransport.cs b/src/core/Akka.Remote/Transport/DotNetty/TcpTransport.cs index a8dce870dd7..792ea620a61 100644 --- a/src/core/Akka.Remote/Transport/DotNetty/TcpTransport.cs +++ b/src/core/Akka.Remote/Transport/DotNetty/TcpTransport.cs @@ -180,8 +180,6 @@ public override bool Write(ByteString payload) private IByteBuffer ToByteBuffer(ByteString payload) { - //TODO: optimize DotNetty byte buffer usage - // (maybe custom IByteBuffer working directly on ByteString?) var buffer = Unpooled.WrappedBuffer(payload.ToByteArray()); return buffer; }