Akka.Delivery at least once in cluster sharding does not respect sharding passivation convention

[Arkatufus]

Version Information
Version of Akka.NET? dev
Which Akka.NET Modules? Akka.Cluster.Sharding

Describe the bug

From Discord.

Normally, a remember entity sharding entity can terminate itself by using Context.Parent.Tell(new Passivate(PoisonPill.Instance). This can't be done when using Akka.Cluster.Sharding.Delivery because there is an extra layer of actor between the Shard actor and the actual user code actor. These actors should just pass the Passivate message to their parents to allow users to use the old passivation convention.

[danne931]

@Arkatufus Thanks for the fix. I can see from logs in my PostStop method that my entity is now passivating. I am wondering if there is still additional cleanup that the consumer controller needs to do given that it is watching the entity. I get an error message about the DeathWatchNotification (ExistenceConfirmed=true, AddressTerminated=false) following the PostStop passivation log:

Any chance this might fix it?
From:

Receive<Passivate>(_ => Sender.Equals(_consumer), p =>
{
   Context.Parent.Tell(p);
});

To:

Receive<Passivate>(_ => Sender.Equals(_consumer), p =>
{
   Context.Unwatch(_consumer);
   Context.Parent.Tell(p);
});

[Arkatufus]

@danne931
The problem with this is that the content of the Passivate message might be incorrect and the entity actor might not get killed by the passivation, that might lead to an unintended behavior. I'll look into this, thanks for the report.

[Arkatufus]

Ah, I think I know what the problem is, the ShardingConsumerController is not shutting down cleanly; the error you're seeing would not cause any problem, it just means that the ConsumerControllers being watched by the ShardingConsumerController died after the ShardingConsumerController actor and the death watch report couldn't reach the actor anymore.
We'll clean this up, but the error should not cause any problem so there's nothing you need to do or worry about.

[Arkatufus]

@danne931 I've opened a new issue to track this here: #7713