Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MNTK specs for DData: DurablePruningSpec #4933

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Fix MNTK specs for DData: DurablePruningSpec #4933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/DurablePruningSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

using System;
using System.Collections.Immutable;
using System.Linq;
using Akka.Actor;
using Akka.Cluster;
using Akka.Cluster.TestKit;
using Akka.Configuration;
using Akka.Remote.TestKit;
Expand Down Expand Up @@ -48,31 +50,41 @@ public class DurablePruningSpec : MultiNodeClusterSpec
private readonly GCounterKey keyA = new GCounterKey("A");
private readonly IActorRef replicator;

protected DurablePruningSpec() : this(new DurablePruningSpecConfig())
public DurablePruningSpec() : this(new DurablePruningSpecConfig())
{
}

protected DurablePruningSpec(DurablePruningSpecConfig config) : base(config, typeof(DurablePruningSpec))
{
InitialParticipantsValueFactory = Roles.Count;
cluster = Akka.Cluster.Cluster.Get(Sys);
replicator = StartReplicator(Sys);
timeout = Dilated(TimeSpan.FromSeconds(5));
}

protected override int InitialParticipantsValueFactory { get; }
protected override int InitialParticipantsValueFactory => Roles.Count;

[MultiNodeFact(Skip = "FIXME")]
[MultiNodeFact]
public void Pruning_of_durable_CRDT_should_move_data_from_removed_node()
{
Join(first, first);
Join(second, first);

var sys2 = ActorSystem.Create(Sys.Name, Sys.Settings.Config);
var cluster2 = Akka.Cluster.Cluster.Get(sys2);
var distributedData2 = DistributedData.Get(sys2);
var replicator2 = StartReplicator(sys2);
var probe2 = new TestProbe(sys2, new XunitAssertions());
cluster2.Join(Node(first).Address);

AwaitAssert(() =>
{
cluster.State.Members.Count.ShouldBe(4);
cluster.State.Members.All(m => m.Status == MemberStatus.Up).ShouldBe(true);
cluster2.State.Members.Count.ShouldBe(4);
cluster2.State.Members.All(m => m.Status == MemberStatus.Up).ShouldBe(true);
}, TimeSpan.FromSeconds(10));
EnterBarrier("joined");

Within(TimeSpan.FromSeconds(5), () => AwaitAssert(() =>
{
replicator.Tell(Dsl.GetReplicaCount);
Expand All @@ -81,10 +93,10 @@ public void Pruning_of_durable_CRDT_should_move_data_from_removed_node()
probe2.ExpectMsg(new ReplicaCount(4));
}));

replicator.Tell(Dsl.Update(keyA, GCounter.Empty, WriteLocal.Instance, c => c.Increment(cluster)));
replicator.Tell(Dsl.Update(keyA, GCounter.Empty, WriteLocal.Instance, c => c.Increment(cluster, 3)));
ExpectMsg(new UpdateSuccess(keyA, null));

replicator2.Tell(Dsl.Update(keyA, GCounter.Empty, WriteLocal.Instance, c => c.Increment(cluster2, 2)), probe2.Ref);
replicator2.Tell(Dsl.Update(keyA, GCounter.Empty, WriteLocal.Instance, c => c.Increment(cluster2.SelfUniqueAddress, 2)), probe2.Ref);
probe2.ExpectMsg(new UpdateSuccess(keyA, null));

EnterBarrier("updates-done");
Expand Down Expand Up @@ -135,8 +147,9 @@ public void Pruning_of_durable_CRDT_should_move_data_from_removed_node()

RunOn(() =>
{
var addr = cluster2.SelfAddress;
var sys3 = ActorSystem.Create(Sys.Name, ConfigurationFactory.ParseString(@"
var address = cluster2.SelfAddress;
var sys3 = ActorSystem.Create(Sys.Name, ConfigurationFactory.ParseString($@"
akka.remote.dot-netty.tcp.port = {address.Port}
").WithFallback(Sys.Settings.Config));
var cluster3 = Akka.Cluster.Cluster.Get(sys3);
var replicator3 = StartReplicator(sys3);
Expand All @@ -151,20 +164,28 @@ public void Pruning_of_durable_CRDT_should_move_data_from_removed_node()
replicator3.Tell(Dsl.Get(keyA, ReadLocal.Instance), probe3.Ref);
var counter4 = probe3.ExpectMsg<GetSuccess>().Get(keyA);
var value = counter4.Value;
values.Add((int) value);
values = values.Add((int) value);
value.ShouldBe(10UL);
counter4.State.Count.ShouldBe(3);
});
values.ShouldBe(ImmutableHashSet.Create(10));
});

// all must at least have seen it as joining
AwaitAssert(() =>
{
cluster3.State.Members.Count.ShouldBe(4);
cluster3.State.Members.All(m => m.Status == MemberStatus.Up).ShouldBeTrue();
}, TimeSpan.FromSeconds(10));

// after merging with others
replicator3.Tell(Dsl.Get(keyA, new ReadAll(RemainingOrDefault)));
var counter5 = ExpectMsg<GetSuccess>().Get(keyA);
counter5.Value.ShouldBe(10UL);
counter5.State.Count.ShouldBe(3);

}, first);

EnterBarrier("sys3-started");

replicator.Tell(Dsl.Get(keyA, new ReadAll(RemainingOrDefault)));
Expand Down