Skip to content

Conversation

@yanpitangui
Copy link
Contributor

@yanpitangui yanpitangui commented Jun 2, 2024

Fixes #7062

Changes

Please provide a brief description of the changes here.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

Include data from the relevant benchmark prior to this change here.

This PR's Benchmarks

Include data from after this change here.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you should add a very simple regression test to verify that this works, mostly to protect us if we make some changes to the test suite in the future. Does that make sense @yanpitangui ?

@Aaronontheweb
Copy link
Member

Aha, looks like we already have a test that touches this and it's now failing as a result of this change: Akka.TestKit.Tests.TestActorRefTests.TestProbeSpec.TestProbe_restart_a_failing_child_if_the_given_supervisor_says_so

my guess is that the test is also wrong - so maybe if we just fix that we should be in good shape @yanpitangui

@Aaronontheweb Aaronontheweb marked this pull request as ready for review December 19, 2024 20:05
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 19, 2024 20:05
@Aaronontheweb Aaronontheweb added the akka-testkit Akka.NET Testkit issues label Dec 19, 2024
@Aaronontheweb Aaronontheweb merged commit 96645a5 into akkadotnet:dev Dec 20, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

akka-testkit Akka.NET Testkit issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TestKit] SupervisorStrategy for TestActor is unused

3 participants