-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make InternalTestActor override its SupervisionStrategy #7221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make InternalTestActor override its SupervisionStrategy #7221
Conversation
Aaronontheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you should add a very simple regression test to verify that this works, mostly to protect us if we make some changes to the test suite in the future. Does that make sense @yanpitangui ?
|
Aha, looks like we already have a test that touches this and it's now failing as a result of this change: my guess is that the test is also wrong - so maybe if we just fix that we should be in good shape @yanpitangui |
Fixes #7062
Changes
Please provide a brief description of the changes here.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.