Skip to content

Conversation

@Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jan 2, 2025

Changes

Add IShardingMessageAdapter interface to Akka.Cluster.Sharding to allow tracing data to be preserved when sharding messages are buffered

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Copy link
Contributor Author

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

{
}

public object Adapt(object message) => message;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method will be used to transform a message before it is stored inside the buffer.

namespace Akka.Cluster.Sharding;

[InternalApi]
public class ShardingSetup: Setup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup class will be used to inject a message adapter into both the ShardRegion and Shard actor during initialization

@Arkatufus Arkatufus marked this pull request as ready for review January 3, 2025 20:15
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants