Make sure that EventSourced timer is cancelled when persistent actor is stopped
#7693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } | ||
|
|
||
| protected override void PostStop() |
Member
There was a problem hiding this comment.
Is there an aroundpoststop or something we can call that can't be overridden by end-users?
Contributor
Author
There was a problem hiding this comment.
good idea, though user can still override AroundPostStop() if they want to since it isn't sealed
….com:Arkatufus/akka.net into akkadotnet#7692-fix-EventSourced-stuck-timer
This was referenced Jul 25, 2025
This was referenced Aug 4, 2025
This was referenced Oct 7, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7692
Changes
Keep track of the currently running timer
ICancelablein a private field instead of a closure variable and make sure that it is being cancelled insidePostStop()