Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factoring module under the OCA #20

Open
dreispt opened this issue May 27, 2024 · 5 comments
Open

Factoring module under the OCA #20

dreispt opened this issue May 27, 2024 · 5 comments

Comments

@dreispt
Copy link

dreispt commented May 27, 2024

Hello @bealdav , @alexis-via

I would like to move the account_factoring_receivable_balance to the OCA.
I think OCA/accoung might be a good home for it.

I'd like to introduce some changes:

  • merge base_factoringinto account_factoring_receivable_balance , as it adds very little itself.
  • move Company level settings to the Journal, to simplify configs and at the same time support multiple Factoring contracts.

I though on renaming account_factoring_receivable_balance to something shorter, but that's not a key thing.

Thoughts?

@rvalyi
Copy link
Member

rvalyi commented May 27, 2024

hello @dreispt , just a word to tell that if one day you want to assume some of the load to put the other factoring module, account_factoring, in the OCA, I'm ready to dedicate a couple of days to help to clean it. It is used in a big solar panel company with a 100M EUR turnover though they asked us all the modules features but kind of use only a part of the features (budget mismatch with this customer). We transferred the customer to Acsone bit I'm afraid the customer will hardly invest to work on moving modules to the OCA sadly. As for the module you asked, I will let David and Alexis answer.

@dreispt
Copy link
Author

dreispt commented May 28, 2024

Thanks @rvalyi

I missed looking at the 14.0 branch and focused on 16.0, that has a very different module.
I now see that the 14,0 version was used to integrate with FactoFrance. that's exactly what I'm asked to to for 17.0.

In that case, I could split the FactoFrance specifics into a l10-france module, and move the account_factoringbase module to https://github.com/OCA/account-payment/

@dreispt
Copy link
Author

dreispt commented Jun 7, 2024

@rvalyi
The 14.0 account_factoringbase goes deep in the accounting and payment records, but it does not implement the TXT files export, and that is my key requirement.

On the other hand, the 16.0 account_factoring_receivable_balance implements a mechanism to export the TXT files, just needs to plug the FactoFrance specific format.

So the 16.0 modules seem closer to my immediate needs.
Thank you

@bealdav
Copy link
Member

bealdav commented Jun 7, 2024

Hi @dreispt account_factoring_receivable_balance was originally created in 15.0. I have migrated to 16.0. Some parts (not used by my customer) are not fully OK with 16 (details parts). My customer doesn't use it anymore in 16.0
Feel free to port to OCA and eventally change the name.

@dreispt
Copy link
Author

dreispt commented Jun 7, 2024

Thank you @bealdav .
Having a go at it here: OCA/l10n-france#555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants