fix for long command line on git-add-interactive

See msysgit#182 for more details This implementation is not checked. It was created from @PhilipDavis proposal https://gist.github.com/PhilipDavis/a7e8843dad39493a698c
albfan · Jul 9, 2014 · 31b228c · 31b228c · PhilipDavis · Jul 9, 2014
1 parent b128d9c
commit 31b228c
Showing 1 changed file with 25 additions and 1 deletion.
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
@@ -175,8 +175,32 @@ sub run_cmd_pipe {
 		my @args = map { m/ /o ? "\"$_\"": $_ } @_;
 		return qx{@args};
 	} else {
+
+		# 2014-08-07 - Phil - Write filename args to a temporary file
+		my @myArgs = @_;
+		my $cmd = "@myArgs";
+		my $path = "$ENV{APPDATA}";
+		$path =~ s/\\/\//g;
+		use File::Temp qw(tempfile);
+		my ($fhargs, $filename) = tempfile("$path/git-args-XXXXXX", UNLINK => 1);
+		if (grep $_ eq "--", @myArgs) {
+			$cmd = "";
+			while ($myArgs[0] ne '--') {
+				$cmd = $cmd . shift(@myArgs) . " ";
+			}
+			$cmd = $cmd . "-- ";
+			shift(@myArgs);
+
+			foreach (@myArgs) {
+				print $fhargs "$_ ";
+			}
+			$fhargs->flush;
+			$cmd = $cmd . "< $filename";
+		}
+
 		my $fh = undef;
-		open($fh, '-|', @_) or die;
+		open($fh, '-|', $cmd) or die;
+		close $fhargs;
 		return <$fh>;
 	}
 }