Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put lines in a div & code lines in a span, Add WrapLongLines Option #571

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

CIAvash
Copy link
Contributor

@CIAvash CIAvash commented Nov 7, 2021

This pull request:

I don't know if tables are needed now, unless they serve a purpose I'm not aware of.

@alecthomas
Copy link
Owner

Nice, have you visually verified that it renders correctly? If not don't worry about it, I'll clone the branch and push it up to the playground so we can mess around.

@alecthomas
Copy link
Owner

I pushed it up, looks good to me. Might be worth taking a look @bep , as this will effect Hugo's output.

@CIAvash
Copy link
Contributor Author

CIAvash commented Nov 8, 2021

Nice, have you visually verified that it renders correctly? If not don't worry about it, I'll clone the branch and push it up to the playground so we can mess around.

Yes, of course, but I haven't tested it in all browsers. Although most of them are chromium-based now, except Firefox and Safari.

Also there might be scenarios that I'm not aware of, so it's better if other people test it as well.

@alecthomas
Copy link
Owner

LGTM, @bep can take a look asynchronously and we can iterate on any issues later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants